Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LMS private key JWKs to prepare for pyjwkest removal #261

Closed
14 tasks done
timmc-edx opened this issue Apr 4, 2023 · 5 comments
Closed
14 tasks done

Update LMS private key JWKs to prepare for pyjwkest removal #261

timmc-edx opened this issue Apr 4, 2023 · 5 comments
Assignees

Comments

@timmc-edx
Copy link
Member

timmc-edx commented Apr 4, 2023

As part of openedx/edx-drf-extensions#290 we need to update our JWKs to be forward-compatible with PyJWT, which requires that either all optional params are present in an RSA JWK, or none are. (With pyjwkest, we've been able to get away with having a partial list of these precomputed values.)

In openedx/edx-platform#31927 we determined that the likely least-friction method of upgrading is to update the private keys in-place to include all of the precomputed private numbers:

@robrap
Copy link
Contributor

robrap commented Apr 17, 2023

@rgraber may be able to help @timmc-edx as eSRE.

@rgraber
Copy link
Contributor

rgraber commented Apr 17, 2023

Yes, I can do this. I ran it by SRE just to be sure and they told me to go for it.

@rgraber
Copy link
Contributor

rgraber commented Apr 18, 2023

@timmc-edx am I correct in assuming I should also do this for sandboxes?

@rgraber rgraber moved this from In Progress to Blocked in Arch-BOM Apr 19, 2023
@rgraber
Copy link
Contributor

rgraber commented Apr 19, 2023

We have decided to update the key rather than roll it since it requires less e/SRE intervention. This is blocked on getting the decrypted private key from SRE, who have it in their sprint.

@rgraber rgraber moved this from Blocked to In Progress in Arch-BOM Apr 20, 2023
@timmc-edx timmc-edx changed the title Roll LMS JWKs to prepare for pyjwkest removal Update LMS private key JWKs to prepare for pyjwkest removal Apr 24, 2023
@rgraber
Copy link
Contributor

rgraber commented Apr 25, 2023

Follow up ticket for updating generate_jwt_signing_key is openedx/edx-platform#32125 . Sandboxes use this to generate keys on provisioning, so updating the script should update sandboxes as well.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Arch-BOM May 9, 2023
@jristau1984 jristau1984 moved this from Done to Done - Long Term Storage in Arch-BOM Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done - Long Term Storage
Development

No branches or pull requests

3 participants