From ca7070978bb1933c7f29b293b01ff8c6bada2e48 Mon Sep 17 00:00:00 2001 From: Robert Raposa Date: Thu, 12 Dec 2024 16:33:26 -0500 Subject: [PATCH] feat!: remove temporary rollout span tag code_owner_plugin The span tag code_owner_plugin was used to rollout code_owner switch from edx-django-utils to the datadog_monitoring plugin in this repo. Now that rollout is complete, this span tag can be removed. Implements: - https://github.com/edx/edx-arch-experiments/issues/784 --- .../datadog_monitoring/code_owner/utils.py | 9 --------- .../datadog_monitoring/tests/code_owner/test_utils.py | 1 - 2 files changed, 10 deletions(-) diff --git a/edx_arch_experiments/datadog_monitoring/code_owner/utils.py b/edx_arch_experiments/datadog_monitoring/code_owner/utils.py index a618504..ec4835e 100644 --- a/edx_arch_experiments/datadog_monitoring/code_owner/utils.py +++ b/edx_arch_experiments/datadog_monitoring/code_owner/utils.py @@ -136,15 +136,6 @@ def set_code_owner_custom_span_tags(code_owner): # to the code_owner span tag. set_custom_attribute('code_owner_squad', code_owner) - # .. custom_attribute_name: code_owner_plugin - # .. custom_attribute_description: This is a temporary span tag to roll out the - # the switch from edx-django-utils to this plugin. If this span tag is True, - # the plugin has added the above custom span tags (possibly in addition to - # edx-django-utils). If the code_owner_theme span tag is also seen, then - # edx-django-utils is also adding these span tags. If not, only the plugin is - # creating these tags. - set_custom_attribute('code_owner_plugin', True) - def set_code_owner_span_tags_from_request(request): """ diff --git a/edx_arch_experiments/datadog_monitoring/tests/code_owner/test_utils.py b/edx_arch_experiments/datadog_monitoring/tests/code_owner/test_utils.py index 3b116e2..94bc525 100644 --- a/edx_arch_experiments/datadog_monitoring/tests/code_owner/test_utils.py +++ b/edx_arch_experiments/datadog_monitoring/tests/code_owner/test_utils.py @@ -169,7 +169,6 @@ def _assert_set_custom_attribute( if code_owner: call_list.append(call('code_owner', code_owner)) call_list.append(call('code_owner_squad', code_owner)) - call_list.append(call('code_owner_plugin', True)) if module: call_list.append(call('code_owner_module', module)) if has_path_error: