From c5aa69ec62e42dc68792ef469e2f594832dc7c9b Mon Sep 17 00:00:00 2001
From: Tim McCormack <tmccormack@edx.org>
Date: Thu, 6 Apr 2023 15:18:39 +0000
Subject: [PATCH] build: Add checks for Makefile and docs (#1047)

Also remove duplicate target from `.PHONY` list.
---
 .github/workflows/quality.yml | 39 +++++++++++++++++++++++++++++++++++
 Makefile                      |  2 +-
 2 files changed, 40 insertions(+), 1 deletion(-)
 create mode 100644 .github/workflows/quality.yml

diff --git a/.github/workflows/quality.yml b/.github/workflows/quality.yml
new file mode 100644
index 0000000000..c80857e698
--- /dev/null
+++ b/.github/workflows/quality.yml
@@ -0,0 +1,39 @@
+# Assorted quality checks for PRs.
+
+name: Quality checks
+
+on:
+  push:
+    branches: [master]
+  pull_request:
+    branches:
+      - '**'
+
+jobs:
+
+  run_ci:
+    runs-on: ubuntu-20.04
+    env:
+      DEVSTACK_WORKSPACE: /tmp
+      SHALLOW_CLONE: 1
+    strategy:
+      matrix:
+        python-version:
+          - '3.8'
+      fail-fast: false
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: setup python
+        uses: actions/setup-python@v2
+        with:
+          python-version: ${{ matrix.python-version }}
+
+      - name: Test Makefile
+        run: make selfcheck
+
+      - name: Install Python dependencies
+        run:  make requirements
+
+      - name: Test that docs build without errors
+        run:  make docs
diff --git a/Makefile b/Makefile
index 10aaa1a281..b130d1e883 100644
--- a/Makefile
+++ b/Makefile
@@ -59,7 +59,7 @@
         dev.up.with-watchers dev.validate docs e2e-tests e2e-tests.with-shell \
         help requirements impl-dev.clone.https impl-dev.clone.ssh impl-dev.provision \
         impl-dev.pull impl-dev.pull.without-deps impl-dev.up impl-dev.up.attach \
-        impl-dev.up.without-deps selfcheck upgrade upgrade \
+        impl-dev.up.without-deps selfcheck upgrade \
         validate-lms-volume vnc-passwords
 
 # Load up options (configurable through options.local.mk).