Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set webpack environment variables. #130

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

dianakhuang
Copy link
Member

This will hopefully fix some issues we're seeing in building static assets.


Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

This will hopefully fix some issues we're seeing in
building static assets.
Copy link

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I be comparing these values to anything, or just give you a thumb so you can see if it works? :)

@dianakhuang
Copy link
Member Author

@robrap we're seeing webpack errors, and the exact message in the paver version is:

WARNING: 'paver webpack' is DEPRECATED! It will be removed before Sumac.
The command you ran is now just a temporary wrapper around a new,
supported command, which you should use instead:

	WEBPACK_CONFIG_PATH=webpack.prod.config.js NODE_ENV=production STATIC_ROOT_LMS=/edx/var/edxapp/staticfiles STATIC_ROOT_CMS=/edx/var/edxapp/staticfiles/studio JS_ENV_EXTRA_CONFIG="{}" npm run webpack

Details: https://github.com/openedx/edx-platform/issues/31895

@dianakhuang dianakhuang merged commit f0a451d into master Dec 12, 2024
3 checks passed
@dianakhuang dianakhuang deleted the diana/paver-fixes branch December 12, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants