Skip to content

Commit

Permalink
temp: enable DD_DJANGO_INSTRUMENT_MIDDLEWARE (#142)
Browse files Browse the repository at this point in the history
Temporarily enabling middleware for end-of-year
to avoid deployments if an issue arises, and to
not have middleware as a blindspot.

See edx/edx-arch-experiments#879
  • Loading branch information
robrap authored Dec 19, 2024
1 parent 6981305 commit 5ace2fe
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion playbooks/roles/edxapp/templates/edx/app/edxapp/cms.sh.j2
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ export DD_TRACE_LOG_STREAM_HANDLER=false

# Suppress middleware spans because there are about 100 for each request.
# Remove (or set to true) for debugging.
export DD_DJANGO_INSTRUMENT_MIDDLEWARE=false
# Temporarily enabled as part of https://github.com/edx/edx-arch-experiments/issues/879
export DD_DJANGO_INSTRUMENT_MIDDLEWARE=true
{% endif -%}

# We want to be able to toggle this on separately from DD in general.
Expand Down
3 changes: 2 additions & 1 deletion playbooks/roles/edxapp/templates/edx/app/edxapp/lms.sh.j2
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ export DD_TRACE_LOG_STREAM_HANDLER=false

# Suppress middleware spans because there are about 100 for each request.
# Remove (or set to true) for debugging.
export DD_DJANGO_INSTRUMENT_MIDDLEWARE=false
# Temporarily enabled as part of https://github.com/edx/edx-arch-experiments/issues/879
export DD_DJANGO_INSTRUMENT_MIDDLEWARE=true

{% endif -%}

Expand Down
3 changes: 2 additions & 1 deletion playbooks/roles/edxapp/templates/edx/app/edxapp/worker.sh.j2
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ export DD_TRACE_LOG_STREAM_HANDLER=false

# Suppress middleware spans because there are about 100 for each request.
# Remove (or set to true) for debugging.
export DD_DJANGO_INSTRUMENT_MIDDLEWARE=false
# Temporarily enabled as part of https://github.com/edx/edx-arch-experiments/issues/879
export DD_DJANGO_INSTRUMENT_MIDDLEWARE=true
{% endif -%}

# We want to be able to toggle this on separately from DD in general.
Expand Down

0 comments on commit 5ace2fe

Please sign in to comment.