From e30d8a831d82e57f46cd526eb5ec191648d72ebc Mon Sep 17 00:00:00 2001 From: Andres Espinel Date: Thu, 21 Mar 2024 18:44:11 -0500 Subject: [PATCH] chore: removed unnecessary code referring the 'private.txt' file --- features/private_package_enabler.feature | 2 -- features/steps/private_package_enabler_step.py | 9 --------- tutordistro/commands/enable_private_packages.py | 4 ---- 3 files changed, 15 deletions(-) diff --git a/features/private_package_enabler.feature b/features/private_package_enabler.feature index 353d4e0..52da0b0 100644 --- a/features/private_package_enabler.feature +++ b/features/private_package_enabler.feature @@ -6,7 +6,6 @@ Feature: Enable private packages And There is a private package When I write the command tutor distro enable-private-packages Then Packages will be cloned into requirements folder - And Packages will be present in the file private.txt @fixture.behave.tutor_root Scenario: Add private package when the package has already been cloned @@ -16,4 +15,3 @@ Feature: Enable private packages And Private package has already been cloned When I write the command tutor distro enable-private-packages and press yes Then Packages will be cloned again into requirements folder - And Packages will be present in the file private.txt diff --git a/features/steps/private_package_enabler_step.py b/features/steps/private_package_enabler_step.py index 2c61f46..714829c 100644 --- a/features/steps/private_package_enabler_step.py +++ b/features/steps/private_package_enabler_step.py @@ -23,15 +23,6 @@ def step_impl(context): # pylint: disable=function-redefined,missing-function-d assert os.path.exists(path) -@then("Packages will be present in the file private.txt") -def step_impl(context): # pylint: disable=function-redefined,missing-function-docstring - distro_packages = get_private_distro_packages(context.scenario.config) - private_file = f"{context.scenario.tutor_root}/env/build/openedx/requirements/private.txt" - with open(private_file, mode="r", encoding="utf-8") as private_requirements_file: - for package in distro_packages.values(): - assert package["name"] in private_requirements_file.read() - - @given("There is a private package") def step_impl(context): # pylint: disable=function-redefined,missing-function-docstring eox_test = { diff --git a/tutordistro/commands/enable_private_packages.py b/tutordistro/commands/enable_private_packages.py index 809ecac..f37a4e4 100644 --- a/tutordistro/commands/enable_private_packages.py +++ b/tutordistro/commands/enable_private_packages.py @@ -8,7 +8,6 @@ from tutor import config as tutor_config from tutordistro.distro.packages.application.package_cloner import PackageCloner -from tutordistro.distro.packages.application.private_package_definer import PrivatePackageDefiner from tutordistro.distro.packages.infrastructure.package_git_repository import PackageGitRepository from tutordistro.utils.packages import get_private_distro_packages @@ -30,7 +29,6 @@ def enable_private_packages(): repository = PackageGitRepository() cloner = PackageCloner(repository=repository) - definer = PrivatePackageDefiner(repository=repository) private_packages = get_private_distro_packages(config) requirements_directory = f"{directory}/env/build/openedx/requirements/" @@ -47,8 +45,6 @@ def enable_private_packages(): }, path=requirements_directory ) - definer(name=package["name"], - file_path=f"{requirements_directory}private.txt") # Run tutor mounts add command for the package subprocess.check_output(f"tutor mounts add {requirements_directory}{package['name']}", shell=True)