Fixed aggregate funcitons name and behavior

edmondop · Jun 20, 2024 · 9446b0b · 9446b0b
1 parent fe8669f
commit 9446b0b
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/datafusion/functions-aggregate/src/min_max.rs b/datafusion/functions-aggregate/src/min_max.rs
@@ -560,7 +560,7 @@ impl AggregateUDFImpl for Max {
     }
 
     fn name(&self) -> &str {
-        "max"
+        "MAX"
     }
 
     fn signature(&self) -> &Signature {
@@ -596,12 +596,11 @@ impl AggregateUDFImpl for Max {
                     PrimitiveGroupsAccumulator::<$PRIMTYPE, _>::new(
                         data_type,
                         |cur, new| {
-                            if *cur > new {
+                            if *cur < new {
                                 *cur = new
                             }
                         },
                     )
-                    // Initialize each accumulator to $NATIVE::MIN
                     .with_starting_value($NATIVE::MIN),
                 ))
             }};
@@ -730,7 +729,7 @@ impl AggregateUDFImpl for Min {
     }
 
     fn name(&self) -> &str {
-        "Min"
+        "MIN"
     }
 
     fn signature(&self) -> &Signature {
@@ -766,13 +765,12 @@ impl AggregateUDFImpl for Min {
                     PrimitiveGroupsAccumulator::<$PRIMTYPE, _>::new(
                         data_type,
                         |cur, new| {
-                            if *cur < new {
+                            if *cur > new {
                                 *cur = new
                             }
                         },
                     )
-                    // Initialize each accumulator to $NATIVE::MIN
-                    .with_starting_value($NATIVE::MIN),
+                    .with_starting_value($NATIVE::MAX),
                 ))
             }};
         }