-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sameAs links between currency-USD and currency-USDollar #1816
Comments
@VladimirAlexiev You should be able to use the inverse query to come up with the name of the currency from the code. The code identifies the currency. When we integrate the OMG Commons ontology library, identifies will be a subproperty of denotes and the redundancy between the two properties will be eliminated. If you use "isIdentifiedBy" in an inverse SPARQL query, though, it all works properly. We have had other users at banks request the names of the currencies as we have them. We have used a pattern for the MIC codes where we have Exchange-code and MIC-code mainly because of (1) the volume of individuals and (2) the difficulty in differentiating the names using algorithms (many are duplicated in the data from ISO). But our policy is not to use codes as you suggest when the number of individuals is small and when the names are well-known and requested by members. The policy stems from the use of the ontology for vocabulary and business glossary purposes in addition to for IT purposes, if that helps. |
Of course I can do it with a query, but most ETL tools cannot do a query (or even simple RDF pattern) while performing ETL. If banks have requested URLs that use English phrases, that's a valid reason to keep it as it is. |
One option would be to add an optional ontology that uses a pattern for what we have called "adjunct" URLs for country codes for a similar purpose - with OWL sameAs to the primary one that uses the name. The adjuct ontology would not start with the code however, it would have Currency-, and CurrencyCode- as the elements, so, for example, Currency-USD would have an owl:sameAs USDollar, and CurrencyCode-USD would have an owl:sameAs USD ... would something like that address your requirement? |
<grant/123> a Grant;
funding <grant/123/funding/NIH>, <grant/123/funding/CDC>;
administeredBy <funder/CD>.
<grant/123/funding/NIH> a Funding; funder <funder/NIH>; amount 10000.
<grant/123/funding/CDC> a Funding; funder <funder/CDC>; amount 12000.
<funder/CDC> a Funder;
idAdministrator "CD"; # only "administeredBy" entities have this short code
idFunder "CDC"; # all funders have this long code
name "Centers for Disease Control".
<funder/CD> owl:sameAs <funder/CDC>. However, |
ISO3166-1-CountryCodes-Adjunct uses
construct {
?curr owl:sameAs ?currAsCode
} where {
?code a fibo-fnd-acc-cur:CurrencyIdentifier; lcc-lr:hasTag ?c; lcc-lr:identifies ?curr.
bind(iri(concat(str(fibo-fnd-acc-4217:),"Currency-",?c)) as ?currAsCode)
} |
@VladimirAlexiev @mereolog We will add a separate ontology that includes the adjuncts as we did for LCC, hopefully soon. The existing URLs will remain, since a number of banks are already using them, but a second ontology with these other codes will be added that includes the owl:sameAs references. I'll have to talk with Pawel (@mereolog) about the timing for scripting this and adding the ontology, but hopefully we can do this relatively soon. |
@ElisaKendall can we close this? |
@merelog - I would rather leave it open for now. We haven't done the work, but that doesn't mean that we shouldn't. It has not been an issue for our FIBO other users, but some folks that want to use currency codes for other applications who are more software oriented might want something similar. |
For reference, I wrote this
Section https://rawgit2.com/VladimirAlexiev/crunchbase-fibo/main/README.html#currencies discusses this problem. |
@VladimirAlexiev This is a really great example. Any chance we can update it to use the latest revisions to FIBO, including migration of some ontologies to the OMG's Commons Ontology Library 1.1 standard? I would be happy to walk through that with you :). |
(was: fibo-fnd-acc-4217:ISO4217-CodeSet individual URLs should use codes not names)
2022Q2 file FND/Accounting/ISO4217-CurrencyCodes.rdf has this:
USDollar
from the codeUSD
fibo-fnd-acc-4217:USD
doesn't have that problem, but financial data relates toCurrency
notCurrencyIdentifier
CB_AGENT_URL()
and then https://github.com/VladimirAlexiev/rdf2rml/blob/master/doc/rdf2sparql.pod#generated-sparql)fibo-fnd-acc-4217:USD-code
andfibo-fnd-acc-4217:USD-currency
respectivelyThe text was updated successfully, but these errors were encountered: