-
Notifications
You must be signed in to change notification settings - Fork 62
Multiroot workspaces support #349
Comments
Hey guys, Do you expect that a separate instance of RLS will be running for each workspace? |
To be honest i haven't really looked too much how it works and it's hard to judge. I can tell how I would expect it to work from user point of view. Whenever I'm editing a specific file in one of the projects or have multiple of them open side by side, every one of them should show me the errors as I type and when those arise. This is how it currently works with single project setup. With the difference that every file could be in different crate. |
I think I have a draft implementation (forked this repo) where I start a separate server per workspace folder. It currently lacks the callbacks for when adding/removing a folder to/from the workspace but that's easy to add. I'll do so this week. From basic tests I did (checking autocomplete and for errors) I didn't see anything wrong. If you are interested I'll update my progress here. |
I was a bit hasty reporting what I have implemented above. |
I've opted for a far simpler approach than my initial one and I have a PR at #355. Any feedback would be much appreciated. |
Version of VSCode: Version 1.16.0-insider
Version of the extension: 0.4.2
OS: MacOS Sierra 10.12.6
Description:
New version of vscode is going to add support for workspaces with multiple root directories. Currently RLS mode starts only for the first project of such workspace. All the rest are simply ignored.
https://code.visualstudio.com/updates/v1_15#_new-api-for-multiroot-workspaces
Output of the "Rust logging" channel:
The text was updated successfully, but these errors were encountered: