-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add the post with headers util function for HTTP clients #955
Conversation
Fixes edgexfoundry#954. Add the post with headers util function for HTTP clients. Signed-off-by: Lindsey Cheng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
recheck |
Signed-off-by: Lindsey Cheng <[email protected]>
Signed-off-by: Lindsey Cheng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
recheck |
Signed-off-by: Lindsey Cheng <[email protected]>
Export SendRequest and CreateRequestWithRawDataAndHeaders functions. Signed-off-by: Lindsey Cheng <[email protected]>
Signed-off-by: Lindsey Cheng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
recheck |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #955 +/- ##
==========================================
- Coverage 42.78% 42.69% -0.09%
==========================================
Files 112 112
Lines 6813 6827 +14
==========================================
Hits 2915 2915
- Misses 3656 3670 +14
Partials 242 242 ☔ View full report in Codecov by Sentry. |
Fixes #954. Add the post with headers util function for HTTP clients.
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)