Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core Metadata] Add "parent" field to Device objects #4769

Open
eaton-coreymutter opened this issue Mar 4, 2024 · 4 comments
Open

[Core Metadata] Add "parent" field to Device objects #4769

eaton-coreymutter opened this issue Mar 4, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@eaton-coreymutter
Copy link

eaton-coreymutter commented Mar 4, 2024

🚀 Feature Request

Relevant Package [REQUIRED]

core-metadata, the Go and C SDKs

Description [REQUIRED]

Implementing the use case in the Device-Parent-Child-Relationships UCR.

Allow Device objects to have an optional "parent": "parent_device_name" property. Allow querying core-metadata for all descendants of a device.

Describe the solution you'd like

  • Add the field, optional "parent":"(device name string)", to the Device objects
  • Update the structures in the Go (go-mod-core-contracts?) and C SDKs.
  • Update core-metadata to disallow deleting a device who is listed as parent of another.
  • Update core-metadata API GET /device/all to add an optional parameter "descendants" with a device-name-string value. If provided, limit results to devices with that device as parent, grandparent, etc.
  • Update Swagger and HTML docs appropriately.

Describe alternatives you've considered

Considered using labels instead in the UCR, decided it was better to have integrity enforcement and query-ability.

@eaton-coreymutter eaton-coreymutter added the enhancement New feature or request label Mar 4, 2024
@eaton-coreymutter eaton-coreymutter moved this to Release Backlog in Technical WG Mar 4, 2024
@cloudxxx8 cloudxxx8 moved this from Release Backlog to New Issues in Technical WG Mar 5, 2024
@cloudxxx8
Copy link
Member

let's discuss in the Core/Device WG meeting

@cloudxxx8
Copy link
Member

In the Core WG meeting today, our conclusion is prefer to just use top-level "parent":"(device name)" for reducing the complexity

@cloudxxx8
Copy link
Member

@eaton-coreymutter the major work of this issue is the API implementation and C SDK work. Do you have any resource to work on this in this release version?

@eaton-coreymutter
Copy link
Author

Just me, I've gotten started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants