Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token approvals - no decimals and token names #2

Open
zanknaf opened this issue Apr 17, 2024 · 0 comments
Open

Token approvals - no decimals and token names #2

zanknaf opened this issue Apr 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@zanknaf
Copy link
Collaborator

zanknaf commented Apr 17, 2024

If there is no asset change (token approval as an example), tenderly does not return Asset change object which contains decimals, so for approval no decimals are provided, models assume 0 decimals places and get the summary wrong.

Example transaction:
0x6661abcb5d7c35e08d3bf70b894e2e3cf0977ba4f203d966cd3db1bf1301f623

Proposed solution:

Add web3 call to get token name and decimals if it is missing in tenderly object (Smart contract is provided in tenderly return object)

Frequency: High
Severity: High

@zanknaf zanknaf added the bug Something isn't working label Apr 17, 2024
@zanknaf zanknaf mentioned this issue Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant