Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ecsact-dev/ecsact_unreal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 56148bec980f44acb7cf2c0e5c12a9fb0d4c9029
Choose a base ref
..
head repository: ecsact-dev/ecsact_unreal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fa659cd9cace462a6259a5a856c2b01960473868
Choose a head ref
Showing with 4 additions and 36 deletions.
  1. +0 −26 Source/Ecsact/Public/EcsactUnreal/EcsactAsyncRunner.cpp
  2. +0 −6 Source/Ecsact/Public/EcsactUnreal/EcsactUnrealExecutionOptions.cpp
  3. +4 −4 renovate.json
26 changes: 0 additions & 26 deletions Source/Ecsact/Public/EcsactUnreal/EcsactAsyncRunner.cpp
Original file line number Diff line number Diff line change
@@ -29,8 +29,6 @@ auto UEcsactAsyncRunner::OnAsyncErrorRaw(
for(auto req_id : request_ids) {
auto cbs = self->RequestErrorCallbacks.Find(req_id);

UE_LOG(Ecsact, Warning, TEXT("async request error id=%i"), req_id);

if(cbs && !cbs->IsEmpty()) {
for(auto& cb : *cbs) {
if(!cb.ExecuteIfBound(async_err)) {
@@ -72,8 +70,6 @@ auto UEcsactAsyncRunner::OnAsyncRequestDoneRaw(
for(auto req_id : request_ids) {
auto cbs = self->RequestDoneCallbacks.Find(req_id);

UE_LOG(Ecsact, Warning, TEXT("async request done id=%i"), req_id);

if(cbs && !cbs->IsEmpty()) {
for(auto& cb : *cbs) {
if(!cb.ExecuteIfBound()) {
@@ -130,12 +126,6 @@ auto UEcsactAsyncRunner::EnqueueExecutionOptions() -> void {
if(ExecutionOptions->IsNotEmpty()) {
auto req_id =
ecsact_async_enqueue_execution_options(*ExecutionOptions->GetCPtr());
UE_LOG(
Ecsact,
Warning,
TEXT("Actually enqueueing some options! (req_id=%i)"),
(int)req_id
);
ExecutionOptions->Clear();
}
}
@@ -152,14 +142,6 @@ auto UEcsactAsyncRunner::OnRequestDone(
FAsyncRequestDoneCallback Callback
) -> void {
check(RequestId != ECSACT_INVALID_ID(async_request));
UE_LOG(
Ecsact,
Error,
TEXT("Adding on request done callback (req_id=%i self=%i)"),
RequestId,
(intptr_t)this
);

RequestDoneCallbacks.FindOrAdd(RequestId).Add(Callback);
}

@@ -168,13 +150,5 @@ auto UEcsactAsyncRunner::OnRequestError(
FAsyncRequestErrorCallback Callback
) -> void {
check(RequestId != ECSACT_INVALID_ID(async_request));
UE_LOG(
Ecsact,
Error,
TEXT("Adding on request error callback (req_id=%i self=%i)"),
RequestId,
(intptr_t)this
);

RequestErrorCallbacks.FindOrAdd(RequestId).Add(Callback);
}
Original file line number Diff line number Diff line change
@@ -75,12 +75,6 @@ auto CreateEntityBuilder::Finish() -> void {
return;
}

UE_LOG(
LogTemp,
Warning,
TEXT("CreateEntityBuilder::Finish() after valid check")
);

Owner->CreateEntityList.Add(PlaceholderId);
Owner->CreateEntityComponentsListNums.Add(ComponentList.Num());
Owner->CreateEntityComponentsList.Push(std::move(ComponentList));
8 changes: 4 additions & 4 deletions renovate.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"local>ecsact-dev/renovate-config"
]
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": [
"local>ecsact-dev/renovate-config"
]
}