You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current dump entities function takes in a registry ID which is not exposed in the async API. Most async implementations have a registry under the hood and could utilise that for easy implementation.
It's unclear to me if this should be part of the serialize or async module. I'm leaning towards the async module.
It's also worth mentioning that this function may need to block, but if we can reasonbly document it being non-blocking or implementation defined that would be okay too. If we're doing non-blocking maybe we shoudl return an ecsact_async_request_id and if we're non-blocking then it should almost certainly be part of the async module.
The text was updated successfully, but these errors were encountered:
The current dump entities function takes in a registry ID which is not exposed in the async API. Most async implementations have a registry under the hood and could utilise that for easy implementation.
Here's the proposed API:
It's unclear to me if this should be part of the
serialize
orasync
module. I'm leaning towards theasync
module.It's also worth mentioning that this function may need to block, but if we can reasonbly document it being non-blocking or implementation defined that would be okay too. If we're doing non-blocking maybe we shoudl return an
ecsact_async_request_id
and if we're non-blocking then it should almost certainly be part of theasync
module.The text was updated successfully, but these errors were encountered: