Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API to dump entities from async runtime #162

Open
zaucy opened this issue Apr 14, 2023 · 0 comments
Open

API to dump entities from async runtime #162

zaucy opened this issue Apr 14, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@zaucy
Copy link
Member

zaucy commented Apr 14, 2023

The current dump entities function takes in a registry ID which is not exposed in the async API. Most async implementations have a registry under the hood and could utilise that for easy implementation.

Here's the proposed API:

void ecsact_async_dump_entities(
	ecsact_dump_entities_callback callback,
	void*                         callback_user_data
);

It's unclear to me if this should be part of the serialize or async module. I'm leaning towards the async module.

It's also worth mentioning that this function may need to block, but if we can reasonbly document it being non-blocking or implementation defined that would be okay too. If we're doing non-blocking maybe we shoudl return an ecsact_async_request_id and if we're non-blocking then it should almost certainly be part of the async module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant