Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should not use both seed and RNG. #1381

Open
alanlujan91 opened this issue Feb 7, 2024 · 4 comments
Open

We should not use both seed and RNG. #1381

alanlujan91 opened this issue Feb 7, 2024 · 4 comments
Assignees

Comments

@alanlujan91
Copy link
Member

We should only expose publicly the seed variable, which internally sets the RNG. The user should never have to create or pass an RNG object, and should never have to use the RNG object directly.

Additionally, recommended seeds are huge strings or numbers, so we should not be using 12345 or the like to set the RNG.

@alanlujan91
Copy link
Member Author

@llorracc
Copy link
Collaborator

llorracc commented Feb 7, 2024 via email

@sbenthall
Copy link
Contributor

Yes, I agree, better discipline around this would be good. We must keep it in mind as we refactor. It is also something that we will need to think about for the DSL design.

@llorracc
Copy link
Collaborator

llorracc commented Feb 7, 2024 via email

@sbenthall sbenthall removed their assignment Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants