diff --git a/CMakeLists.txt b/CMakeLists.txt index 3a281ae6f..d92311448 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -276,9 +276,6 @@ if( HAVE_RSYNC ) set( LIBRSYNC_LIBRARIES rsync ) endif() -ecbuild_add_option( FEATURE SANDBOX - DEFAULT OFF - DESCRIPTION "Sandbox playground for prototyping code that may never see the light of day" ) ### Performance tests diff --git a/VERSION b/VERSION index cfc730712..450a687b2 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -1.28.0 +1.28.1 diff --git a/src/eckit/codec/Stream.cc b/src/eckit/codec/Stream.cc index 96bdbc5c4..5a49f4d4f 100644 --- a/src/eckit/codec/Stream.cc +++ b/src/eckit/codec/Stream.cc @@ -25,8 +25,6 @@ Stream::Stream(DataHandle* datahandle) : shared_(datahandle), ptr_(shared_.get() Stream::Stream(std::shared_ptr datahandle) : shared_(datahandle), ptr_(shared_.get()) {} -Stream::Stream(const Stream& other) = default; - DataHandle& Stream::datahandle() { ASSERT(ptr_ != nullptr); return *ptr_; diff --git a/src/eckit/codec/Stream.h b/src/eckit/codec/Stream.h index 3c5ecc258..8f2fe3c9d 100644 --- a/src/eckit/codec/Stream.h +++ b/src/eckit/codec/Stream.h @@ -46,8 +46,11 @@ class Stream { /// the referenced datahandle Stream(DataHandle&); - /// Assignment constructor sharing datahandle with other Stream - Stream(const Stream&); + /// Assignment/Copy constructor sharing datahandle with other Stream + Stream(const Stream&) = default; + Stream(Stream&&) = default; + Stream& operator=(const Stream&) = default; + Stream& operator=(Stream&&) = default; /// Access internal DataHandle DataHandle& datahandle(); diff --git a/src/eckit/linalg/CMakeLists.txt b/src/eckit/linalg/CMakeLists.txt index 6ac07e178..ce062036e 100644 --- a/src/eckit/linalg/CMakeLists.txt +++ b/src/eckit/linalg/CMakeLists.txt @@ -90,6 +90,10 @@ ecbuild_add_library( TARGET eckit_linalg TYPE SHARED PRIVATE_LIBS ${eckit_la_plibs} ) if( eckit_HAVE_EIGEN ) + if(NOT EIGEN3_INCLUDE_DIRS AND TARGET Eigen3::Eigen) + get_target_property(EIGEN3_INCLUDE_DIRS Eigen3::Eigen INTERFACE_INCLUDE_DIRECTORIES) + endif() + # Add include directories with "SYSTEM" to avoid warnings from within Eigen headers target_include_directories( eckit_linalg SYSTEM PRIVATE ${EIGEN3_INCLUDE_DIRS} ) endif() diff --git a/src/eckit/linalg/sparse/LinearAlgebraEigen.cc b/src/eckit/linalg/sparse/LinearAlgebraEigen.cc index 39b9fd1d5..34159cca8 100644 --- a/src/eckit/linalg/sparse/LinearAlgebraEigen.cc +++ b/src/eckit/linalg/sparse/LinearAlgebraEigen.cc @@ -26,7 +26,7 @@ static const LinearAlgebraEigen __la("eigen"); using vec_t = Eigen::VectorXd::MapType; using mat_t = Eigen::MatrixXd::MapType; -using spm_t = Eigen::MappedSparseMatrix; +using spm_t = Eigen::Map>; void LinearAlgebraEigen::print(std::ostream& out) const { diff --git a/src/eckit/maths/CMakeLists.txt b/src/eckit/maths/CMakeLists.txt index bc4cac86c..26d971030 100644 --- a/src/eckit/maths/CMakeLists.txt +++ b/src/eckit/maths/CMakeLists.txt @@ -24,7 +24,11 @@ ecbuild_add_library( PUBLIC_LIBS eckit ) -if(HAVE_EIGEN) +if(eckit_HAVE_EIGEN) + if(NOT EIGEN3_INCLUDE_DIRS AND TARGET Eigen3::Eigen) + get_target_property(EIGEN3_INCLUDE_DIRS Eigen3::Eigen INTERFACE_INCLUDE_DIRECTORIES) + endif() + # Add include directories with "SYSTEM" to avoid warnings from within Eigen headers target_include_directories(eckit_maths SYSTEM PUBLIC ${EIGEN3_INCLUDE_DIRS}) endif() diff --git a/tests/value/CMakeLists.txt b/tests/value/CMakeLists.txt index bd7558e0e..ffb946b0f 100644 --- a/tests/value/CMakeLists.txt +++ b/tests/value/CMakeLists.txt @@ -29,7 +29,7 @@ foreach( valueType nil boolean integer double string valuemap valuelist date ord LIBS eckit ) endforeach() -if( CMAKE_CXX_COMPILER_ID MATCHES "Cray" ) +if( CMAKE_CXX_COMPILER_ID STREQUAL "Cray" ) # Disable warnings for test_value_integer due to following: # "Integer conversion resulted in a change of sign." set_source_files_properties(test_value_integer.cc PROPERTIES COMPILE_FLAGS "-hmsglevel_4" )