Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss Integration of Multi-LAM Support in graphs #58

Open
paulina-t opened this issue Jan 2, 2025 · 2 comments
Open

Discuss Integration of Multi-LAM Support in graphs #58

paulina-t opened this issue Jan 2, 2025 · 2 comments
Labels
enhancement New feature or request graphs

Comments

@paulina-t
Copy link

Is your feature request related to a problem? Please describe.

I have implemented multi-LAM support for anemoi-graphs, extending its functionality to handle multiple Limited Area Models (LAMs) with hierarchical masking and varying resolutions. This feature allows the graph to handle different overlapping (or not) LAM domains, such as MEPS and AROME-Arctic.

Since all development now takes place in the consolidated anemoi-core repository, I would like to discuss the next steps for merging this feature, if appropriate.

Describe the solution you'd like

If this is of interest to others than MET Norway, I propose integrating the multi-LAM support functionality into anemoi-core. The implementation is compatible with the latest anemoi-datasets updates, which include multi-LAM hierarchical masking.

Describe alternatives you've considered

None at the moment, as this implementation addresses the need for managing multi-LAMs in the graph.

Additional context

Here are some key points for discussion:

  1. Need for Discussion or Direct PR:

    • Should we open a PR directly for the implementation, or is a preliminary discussion needed to align on design and integration details?
    • When is good timing?
  2. Compatibility with anemoi-core:

    • The implementation is compatible with the latest anemoi-datasets multi-LAM updates.
    • Are there additional requirements specific to anemoi-core that should be addressed?
  3. Testing:

    • Do we need additional testing steps within the anemoi-core context?

Below is an example of how the mesh looks with different refinements and hierarchical cutout for ERA5, AROME-Arctic, and MEPS.

image
image

@JPXKQX

Organisation

Norwegian Meteorological Institute

@paulina-t paulina-t added enhancement New feature or request graphs labels Jan 2, 2025
@JPXKQX
Copy link
Member

JPXKQX commented Jan 7, 2025

Hi Paulina, thank you for bringing this up and already working on an implementation! I think the best approach would be to open a draft PR so we can review and discuss any necessary changes directly there. I'm also happy to meet if you'd like to discuss the work further. Just a note that in anemoi-core, we'll need to wait for the CI pipelines to be set up and successfully passed before merging the changes (this is a work in progress)

@paulina-t
Copy link
Author

Thank you, Mario, for your feedback! Opening a draft PR sounds like a great plan, but since there’s no rush on my end, I’m happy to wait until the CI pipelines are fully set up and operational before submitting it.

Looking forward to collaborating on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request graphs
Projects
None yet
Development

No branches or pull requests

2 participants