Training reorder parameter names for plot #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mc4117
reviewed
Dec 30, 2024
| parts = s.split("_") | ||
| alpha_part = s if len(parts) == 1 else s[: -len(parts[-1]) - 1] | ||
| numeric_part = int(parts[-1]) if len(parts) > 1 and parts[-1].isdigit() else float("inf") | ||
| return (alpha_part, numeric_part, s) |
There was a problem hiding this comment.
Why do you need to return s here too?
There was a problem hiding this comment.
If alpha_part and numeric part are the same for two different variables, the entire variable name s is used for sorting.
mc4117
reviewed
Dec 30, 2024
| @@ -824,6 +828,24 @@ def automatically_determine_group(name: str) -> str: | |||
| legend_patches, | |||
| ) | |||
|
|
|||
| def argsort_name_variablelevel(self) -> list[int]: | |||
There was a problem hiding this comment.
Would it be worth putting this in to a callback or loss utils? I can see this function being useful for other callbacks in the future
There was a problem hiding this comment.
That's right. Will do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the newer versions of anemoi-datasets from MARS the variables are not ordered by pressure level anymore but by alphabet, meaning that the order in the loss-plot is also by alphabet (100 is then "smaller" than 20). However, the analysis of the loss weights is more intuitive when ordered by pressure level (or model level).
This PR sorts the variables (for this specific plotting function) in one group by the variable level (if available) interpreting them as digits not strings.