Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] available_frontends: Import pytest locally to make dependency optional #290

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

reuterbal
Copy link
Collaborator

This is a hotfix following merge of #287

@reuterbal reuterbal requested a review from mlange05 April 16, 2024 08:49
Copy link

Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/290/index.html

Copy link
Collaborator

@mlange05 mlange05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thanks for fixing. Yes, looks good to me. GTG :shipit:

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 94.92%. Comparing base (4068b82) to head (953fa77).

Files Patch % Lines
loki/frontend/util.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
- Coverage   94.93%   94.92%   -0.01%     
==========================================
  Files         152      152              
  Lines       31411    31415       +4     
==========================================
+ Hits        29820    29821       +1     
- Misses       1591     1594       +3     
Flag Coverage Δ
lint_rules 96.39% <ø> (ø)
loki 95.09% <50.00%> (-0.01%) ⬇️
transformations 92.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reuterbal reuterbal added the ready for merge This PR has been approved and is ready to be merged label Apr 16, 2024
@reuterbal reuterbal merged commit a68709b into main Apr 16, 2024
12 checks passed
@reuterbal reuterbal deleted the nabr-fix-pytest-dependency branch April 16, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge This PR has been approved and is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants