Fixing nested associate scope-parentage tracking after inlining #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/281/index.html |
This is needed to correctly infer parentage among scoped IR nodes is they have been moved (eg. via inlining associates).
mlange05
force-pushed
the
naml-fix-inline-nested-assoc
branch
from
892e01c
to
da93e18
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
+ Coverage 92.83% 92.85% +0.01%
==========================================
Files 102 102
Lines 18121 18165 +44
==========================================
+ Hits 16823 16867 +44
Misses 1298 1298
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
reuterbal
approved these changes
Apr 10, 2024
Comment on lines
+921
to
+923
| assert call.name == 'rick_is' | ||
| assert call.arguments == ('never%going_to%give_you%up',) | ||
| # Q. E. D. |
reuterbal
added
the
ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A curious corner case when inlining procedures that would result in nested associates, as the newly created parentage cannot be inferred via the usual pin-hole insertion approach. So, instead we now ensure that we update the parent in
AttachScopesand call this after the call-inlining is finalised. A test is provided that illustrates the problem.