Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobalVariableAnalysis not working for global variables only used in the routine.spec e.g., as array dimension #244

Open
MichaelSt98 opened this issue Mar 12, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@MichaelSt98
Copy link
Collaborator

Problem with GlobalVariableAnalysis as global variables only used in the routine.spec e.g., as array dimension are not captured in uses_symbols. Reason being:

  1. transform_subroutine only accounts for routine.body.uses_symbols (and routine.body.defines_symbols), disregarding the routine.spec
  2. dataflow_analysis_attached(routine) wouldn't include variables in VariableDeclarations in uses_symbols

Because of (2), this could also result in unwanted behaviour beyond GlobalVariableAnalysis.

@MichaelSt98 MichaelSt98 added bug Something isn't working enhancement New feature or request labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant