New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loki_transform for CUF variants, bundle.yml fixup #99

Merged

reuterbal merged 2 commits into naml-loki-config-from-file from nabr-naml-loki-config-from-file-fixups

Nov 4, 2024

Collaborator

reuterbal commented Nov 4, 2024

A small fixup to PR #94:

The help string in bundle.yml made this invalid YAML, which broke the --help option of ecbundle
the CUDA Fortran still used the outdated loki_transform_convert interface. I flipped this to loki_transform, which means we'll be able to remove the old macro from loki, too.

reuterbal added 2 commits

November 4, 2024 16:16


          Fix help string in bundle.yml

2b59d8f


          CMake: Use loki_transform for CUF variants

631ac1d

reuterbal requested a review from mlange05

November 4, 2024 15:33

mlange05 approved these changes

View reviewed changes

Collaborator

mlange05 left a comment

Yes, looks good to me.

reuterbal merged commit c5fe161 into naml-loki-config-from-file

18 checks passed

reuterbal deleted the nabr-naml-loki-config-from-file-fixups branch

November 4, 2024 16:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet