Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nodeSelector, tolerations and serviceAccounts to deployments/statefulsets in Hono Chart #445

Open
burhanuguz opened this issue Jan 11, 2023 · 1 comment

Comments

@burhanuguz
Copy link

Hi,

To install hono in production environment effectively, we need to have nodeSelectors, tolerations and serviceAccount definitions in the deployment/statefulset templates.

Since there is no implementation of it, we edited those templates manually and add values to the values yaml. We are deploying every hono deployment/statefulsets to the same nodes so we only put nodeSelector and tolerations variables in those templates. It would be much better if you could add those variables to each deployment/statefulset with _helpers.tpl templating.

spec:
  nodeSelector: {{- toYaml .Values.nodeSelector | nindent 8 }}
  tolerations: {{- toYaml .Values.tolerations | nindent 8 }}
  serviceAccount: {{ .Values.serviceAccountName }}
@burhanuguz burhanuguz changed the title nodeSelector, tolerations and serviceAccounts for deployments/statefulsets Add nodeSelector, tolerations and serviceAccounts to deployments/statefulsets in Hono Chart Jan 11, 2023
@sophokles73
Copy link
Member

Thanks for the suggestion. We would be happy to accept a corresponding PR.

@calohmn calohmn added the Hono label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants