Replies: 3 comments
-
@Channyboy @donbourne I know this is not a week we'd normally meet, but I at least would be available for an ad hoc meeting Tuesday--our normal time or nearly any other time (avoiding 1-2 Eastern)--to talk about this. |
Beta Was this translation helpful? Give feedback.
0 replies
-
@jgallimore I did not mean to leave you out of this! |
Beta Was this translation helpful? Give feedback.
0 replies
-
Daniel and I have been chatting vigorously about this in gitter here: https://app.gitter.im/#/room/#eclipse_microprofile-metrics:gitter.im |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
@Channyboy @donbourne I mentioned this briefly in the MP metrics gitter channel but wanted to tag you here as well. Sorry for the multiple hits.
I'm working on an implementation for MP metrics 5.0.1 but I'm finding several TCK tests fail for me because different beans declare the same metric via annotations but with conflicting tag name sets (which the spec outlaws).
Specifically, the TCK contains
CountedMethodBean
andCountedMethodTagBean
which declare via annotation "countedMethod" but with different tag name sets.There are individual test classes for each of those two bean classes, and each of those specific tests selects only the relevant class in building the test deployment archive.
But quite a few other tests (
MPMetricBaseMetricsTest
is one) are failing (for me) because they see both of those classes and trigger the spec-mandatedIllegalArgumentException
because the the annotations do not all specify the same tag names.I'm having trouble seeing how the code I'm working on could cause this. I've wondered if our Arquillian adapter might somehow include things it shouldn't so that the TCK expects those two beans will not be included in all those other tests but for some reason they are, but the same adapter seems to be working for the other MP technologies.
Any ideas?
Beta Was this translation helpful? Give feedback.
All reactions