Update z_api_alignment_test for compatiblity with zenoh-c build #296
Conversation
| @@ -215,9 +221,9 @@ int main(int argc, char **argv) { | |||
| assert(hellos >= 1); | |||
|
|
|||
| uint32_t _scouting_timeout = strtoul(SCOUTING_TIMEOUT, NULL, 10); | |||
| z_sleep_ms(_scouting_timeout); | |||
| sleep(_scouting_timeout / 1000); | |||
There was a problem hiding this comment.
In Zenoh-Pico/Zenoh-C we should better use z_sleep_* and avoid using platform-specific syscalls.
However, those functions are still missing in Zenoh-C (see eclipse-zenoh/zenoh-c#183).
Nevertheless, they are present in Zenoh-Pico, so better keep them.
There was a problem hiding this comment.
But as far as I understand, the idea is for the files to be identical in both repos, do you think adding a #define here would be reasonable?
There was a problem hiding this comment.
I would say that the additional functions shall be added in zenoh-c, as referred by @Mallets.
There was a problem hiding this comment.
Yes, sure, but until we have no them in zenohc, api alignment test on them has no sense.
| @@ -26,7 +26,11 @@ | |||
| #include <unistd.h> | |||
| #endif | |||
|
|
|||
| #ifdef ZENOH_PICO | |||
| #include "zenoh-pico.h" | |||
There was a problem hiding this comment.
Tests are also failing because the ZENOH_PICO checked before its definition in zenoh-pico.h include
|
Close because seems currently on zenoh-c side this test require a lot of rework. |
No description provided.