Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Tests compilation fails #80

Closed
Mallets opened this issue Nov 7, 2023 · 1 comment
Closed

[Bug] Tests compilation fails #80

Mallets opened this issue Nov 7, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@Mallets
Copy link
Member

Mallets commented Nov 7, 2023

Describe the bug

Tests compilation fails when targeting zenoh-pico:

Scanning dependencies of target warnings_zenohpico
[ 73%] Building CXX object tests/CMakeFiles/warnings_zenohpico.dir/build/warnings.cxx.o
In file included from /tmp/zenoh-cpp/include/zenohpico.hxx:28,
                 from /tmp/zenoh-cpp/include/zenoh.hxx:25,
                 from /tmp/zenoh-cpp/tests/build/warnings.cxx:26:
/tmp/zenoh-cpp/include/zenohcxx/impl.hxx:329:2: error: extra ‘;’ [-Werror=pedantic]
  329 | };
      |  ^
/tmp/zenoh-cpp/include/zenohcxx/impl.hxx:577:2: error: extra ‘;’ [-Werror=pedantic]
  577 | };
      |  ^
cc1plus: all warnings being treated as errors
make[3]: *** [tests/CMakeFiles/warnings_zenohpico.dir/build.make:63: tests/CMakeFiles/warnings_zenohpico.dir/build/warnings.cxx.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:307: tests/CMakeFiles/warnings_zenohpico.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:571: tests/CMakeFiles/tests.dir/rule] Error 2
make: *** [Makefile:340: tests] Error 2

I assume a similar fix should be done as in #79

To reproduce

  1. Clone zenoh-cpp
  2. Compile tests with cmake --build . --target tests

System info

Ubuntu 20.04.6 LTS
AMD Ryzen 7 5800X

@Mallets Mallets added the bug Something isn't working label Nov 7, 2023
@Mallets
Copy link
Member Author

Mallets commented Nov 8, 2023

Fixed by #81

@Mallets Mallets closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant