Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication wrappers can be initialized with closed uTransport #172

Open
mishap4 opened this issue Jul 25, 2024 · 0 comments
Open

Communication wrappers can be initialized with closed uTransport #172

mishap4 opened this issue Jul 25, 2024 · 0 comments

Comments

@mishap4
Copy link

mishap4 commented Jul 25, 2024

For example InMemortyRpcClient can be created with a closed uTransport instance. It calls uTransport.registerListener in constructor which fails and never retried.
Do we want to allow creation of communication wrappers passing not opened uTransport instance? Then we need a callback interface from uTransport to notify its state changes.
Or we must fail wrapper creation with a closed transport as an argument. But then wrapper reference cannot be initialized ahead (before transport is connected) and the code should check for null before using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant