Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trace-server: add IdentifierService #17

Merged
merged 1 commit into from
May 14, 2024
Merged

trace-server: add IdentifierService #17

merged 1 commit into from
May 14, 2024

Conversation

vladarama
Copy link
Contributor

This PR adds a service to identify important information regarding the trace server and the system it is running on.
It also includes testing this IdentifierService.

bhufmann
bhufmann requested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting this contribution.

...racecompass/incubator/internal/trace/server/jersey/rest/core/services/IdentifierService.java Outdated Show resolved Hide resolved
...racecompass/incubator/internal/trace/server/jersey/rest/core/services/IdentifierService.java Outdated Show resolved Hide resolved
...racecompass/incubator/internal/trace/server/jersey/rest/core/services/IdentifierService.java Outdated Show resolved Hide resolved
...racecompass/incubator/internal/trace/server/jersey/rest/core/services/IdentifierService.java Outdated Show resolved Hide resolved
...racecompass/incubator/internal/trace/server/jersey/rest/core/services/IdentifierService.java Outdated Show resolved Hide resolved
...racecompass/incubator/internal/trace/server/jersey/rest/core/services/IdentifierService.java Outdated Show resolved Hide resolved
...racecompass/incubator/internal/trace/server/jersey/rest/core/services/IdentifierService.java Outdated Show resolved Hide resolved
...racecompass/incubator/internal/trace/server/jersey/rest/core/services/IdentifierService.java Outdated Show resolved Hide resolved
...racecompass/incubator/internal/trace/server/jersey/rest/core/services/IdentifierService.java Outdated Show resolved Hide resolved
@vladarama vladarama requested a review from bhufmann April 25, 2024 17:45
bhufmann
bhufmann requested changes May 1, 2024
View reviewed changes
...ompass/incubator/internal/trace/server/jersey/rest/core/services/ServerInfoResponseImpl.java Show resolved Hide resolved
...ompass/incubator/internal/trace/server/jersey/rest/core/services/ServerInfoResponseImpl.java Show resolved Hide resolved
...ompass/incubator/internal/trace/server/jersey/rest/core/services/ServerInfoResponseImpl.java Show resolved Hide resolved
...ompass/incubator/internal/trace/server/jersey/rest/core/services/ServerInfoResponseImpl.java Show resolved Hide resolved
...ompass/incubator/internal/trace/server/jersey/rest/core/services/ServerInfoResponseImpl.java Show resolved Hide resolved
...ompass/incubator/internal/trace/server/jersey/rest/core/services/ServerInfoResponseImpl.java Show resolved Hide resolved
...ompass/incubator/internal/trace/server/jersey/rest/core/services/ServerInfoResponseImpl.java Show resolved Hide resolved
.../tracecompass/incubator/internal/trace/server/jersey/rest/core/model/ServerInfoResponse.java Show resolved Hide resolved
.../tracecompass/incubator/internal/trace/server/jersey/rest/core/model/ServerInfoResponse.java Show resolved Hide resolved
...ompass/incubator/internal/trace/server/jersey/rest/core/services/ServerInfoResponseImpl.java Outdated Show resolved Hide resolved
@vladarama vladarama requested a review from bhufmann May 2, 2024 13:59
bhufmann
bhufmann requested changes May 6, 2024
View reviewed changes
Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some more comments. Thanks for the updates.

.../tracecompass/incubator/internal/trace/server/jersey/rest/core/model/ServerInfoResponse.java Outdated Show resolved Hide resolved
...racecompass/incubator/internal/trace/server/jersey/rest/core/services/IdentifierService.java Outdated Show resolved Hide resolved
...racecompass/incubator/internal/trace/server/jersey/rest/core/services/IdentifierService.java Outdated Show resolved Hide resolved
...racecompass/incubator/internal/trace/server/jersey/rest/core/services/IdentifierService.java Outdated Show resolved Hide resolved
...racecompass/incubator/internal/trace/server/jersey/rest/core/services/IdentifierService.java Outdated Show resolved Hide resolved
...racecompass/incubator/internal/trace/server/jersey/rest/core/services/IdentifierService.java Outdated Show resolved Hide resolved
...racecompass/incubator/internal/trace/server/jersey/rest/core/services/IdentifierService.java Outdated Show resolved Hide resolved
...racecompass/incubator/internal/trace/server/jersey/rest/core/services/IdentifierService.java Outdated Show resolved Hide resolved
...racecompass/incubator/internal/trace/server/jersey/rest/core/services/IdentifierService.java Outdated Show resolved Hide resolved
@vladarama vladarama requested a review from bhufmann May 6, 2024 18:41
bhufmann
bhufmann approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@bhufmann bhufmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@MatthewKhouzam MatthewKhouzam merged commit f287f0f into eclipse-tracecompass-incubator:master May 14, 2024
2 checks passed
@vladarama vladarama deleted the backend-identifier branch July 19, 2024 14:57
This was referenced Aug 7, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatthewKhouzam MatthewKhouzam MatthewKhouzam approved these changes

@bhufmann bhufmann bhufmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vladarama @bhufmann @MatthewKhouzam