Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rest): Create new endpoint for schedule CVE and schedule attachment deletion in admin tab. #2243

Merged
merged 1 commit into from
Oct 22, 2024
Merged

feat(rest): Create new endpoint for schedule CVE and schedule attachment deletion in admin tab. #2243

merged 1 commit into from
Oct 22, 2024

Conversation

nikkuma7
Copy link
Contributor

@nikkuma7 nikkuma7 commented Dec 14, 2023 •
edited
Loading

…ent deletion.

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?

Closes #2242

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

http://localhost:8080/resource/api/schedule/cveService
http://localhost:8080/resource/api/schedule/unscheduleCve
http://localhost:8080/resource/api/schedule/deleteAttachment
http://localhost:8080/resource/api/schedule/unscheduleService
http://localhost:8080/resource/api/schedule/DeleteOldAttachment
http://localhost:8080/resource/api/schedule/cveSearch

How should these changes be tested by the reviewer?
Have you implemented any additional tests?

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@nikkuma7
Copy link
Contributor Author

Please first merge pr #2238

@ag4ums ag4ums added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Dec 15, 2023
@nikkuma7 nikkuma7 force-pushed the feat/scheduleCVE_And_AttachmentDeletion_in_schedule branch 2 times, most recently from 51f957f to ac3e663 Compare January 4, 2024 06:27
@nikkuma7 nikkuma7 force-pushed the feat/scheduleCVE_And_AttachmentDeletion_in_schedule branch from ac3e663 to abe709e Compare January 11, 2024 06:13
@nikkuma7
Copy link
Contributor Author

Merge conflicts resolved

@nikkuma7 nikkuma7 force-pushed the feat/scheduleCVE_And_AttachmentDeletion_in_schedule branch from abe709e to 786c7f5 Compare January 11, 2024 06:34
@ag4ums ag4ums mentioned this pull request Jan 16, 2024
Merged
1 task
@keerthi-bl
Copy link
Contributor

Taking this PR for testing

@keerthi-bl
Copy link
Contributor

Test completed.

image

image

image

image

image

image

Need one clarity @nikkuma7 :

In below code (in screenshot), is that http type is proper!!? Delete api has Post method and Unschedule method has Delete method type..!!

image

@nikkuma7
Copy link
Contributor Author

Hi @keerthi-bl , As you can see in below SS
image

its correct Attachment deletion method should have post method, because we are scheduling when we click on deletion button.

@rudra-superrr rudra-superrr removed the needs general test This is general testing, meaning that there is no org specific issue to check for label Mar 8, 2024
smrutis1
smrutis1 requested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@smrutis1 smrutis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the review comments and seems like the exception handing is not proper. Kindly address those.

...erver/src/main/java/org/eclipse/sw360/rest/resourceserver/schedule/Sw360ScheduleService.java Outdated Show resolved Hide resolved
...erver/src/main/java/org/eclipse/sw360/rest/resourceserver/schedule/Sw360ScheduleService.java Outdated Show resolved Hide resolved
...er/src/main/java/org/eclipse/sw360/rest/resourceserver/schedule/ScheduleAdminController.java Outdated Show resolved Hide resolved
rest/resource-server/src/docs/asciidoc/schedule.adoc Outdated Show resolved Hide resolved
@smrutis1
Copy link
Contributor

Hi @keerthi-bl , As you can see in below SS image

its correct Attachment deletion method should have post method, because we are scheduling when we click on deletion button.

Please use the POST method across the schedule endpoints ad it is not actually deleting the resourcse instead, it is triggering an action.

@nikkuma7 nikkuma7 force-pushed the feat/scheduleCVE_And_AttachmentDeletion_in_schedule branch from 786c7f5 to cf1872a Compare March 27, 2024 09:07
@heliocastro heliocastro added the New-UI Level for the API and UI level changes for the new-ui label Mar 27, 2024
@nikkuma7 nikkuma7 force-pushed the feat/scheduleCVE_And_AttachmentDeletion_in_schedule branch from cf1872a to 433af87 Compare March 27, 2024 10:54
@smrutis1
Copy link
Contributor

Hi @keerthi-bl , As you can see in below SS image
its correct Attachment deletion method should have post method, because we are scheduling when we click on deletion button.

Please use the POST method across the schedule endpoints ad it is not actually deleting the resourcse instead, it is triggering an action.

Kindly address this one.

@keerthi-bl
Copy link
Contributor

@smrutis1 : I agreed with your comments. It looks good to me as well.

Hi @keerthi-bl , As you can see in below SS image
its correct Attachment deletion method should have post method, because we are scheduling when we click on deletion button.

Please use the POST method across the schedule endpoints ad it is not actually deleting the resourcse instead, it is triggering an action.

Kindly address this one.

@nikkuma7 nikkuma7 force-pushed the feat/scheduleCVE_And_AttachmentDeletion_in_schedule branch 2 times, most recently from 107bbe1 to c73a4de Compare May 2, 2024 07:24
@nikkuma7
Copy link
Contributor Author

nikkuma7 commented May 2, 2024

Kindly address this one.

done.

@GMishx
Copy link
Member

GMishx commented Sep 6, 2024

@nikkuma7 please rebase with latest main

@nikkuma7 nikkuma7 force-pushed the feat/scheduleCVE_And_AttachmentDeletion_in_schedule branch from c73a4de to db4e551 Compare October 21, 2024 07:43
@nikkuma7 nikkuma7 force-pushed the feat/scheduleCVE_And_AttachmentDeletion_in_schedule branch from db4e551 to f3ef845 Compare October 21, 2024 08:28
GMishx
GMishx requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes needed.

...er/src/main/java/org/eclipse/sw360/rest/resourceserver/schedule/ScheduleAdminController.java Outdated Show resolved Hide resolved
...er/src/main/java/org/eclipse/sw360/rest/resourceserver/schedule/ScheduleAdminController.java Outdated Show resolved Hide resolved
...ce-server/src/test/java/org/eclipse/sw360/rest/resourceserver/restdocs/ScheduleSpecTest.java Outdated Show resolved Hide resolved
...ce-server/src/test/java/org/eclipse/sw360/rest/resourceserver/restdocs/ScheduleSpecTest.java Outdated Show resolved Hide resolved
@nikkuma7 nikkuma7 force-pushed the feat/scheduleCVE_And_AttachmentDeletion_in_schedule branch from f3ef845 to aacf0dd Compare October 22, 2024 05:42
GMishx
GMishx approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@GMishx GMishx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good.

@GMishx GMishx added ready ready to merge and removed needs code review labels Oct 22, 2024
smrutis1
smrutis1 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@smrutis1 smrutis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

@GMishx GMishx merged commit cd97b61 into eclipse-sw360:main Oct 22, 2024
2 checks passed
@GMishx GMishx deleted the feat/scheduleCVE_And_AttachmentDeletion_in_schedule branch October 22, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smrutis1 smrutis1 smrutis1 approved these changes

@GMishx GMishx GMishx approved these changes

@heliocastro heliocastro Awaiting requested review from heliocastro heliocastro is a code owner

@KoukiHama KoukiHama Awaiting requested review from KoukiHama KoukiHama is a code owner

@arunazhakesan arunazhakesan Awaiting requested review from arunazhakesan arunazhakesan is a code owner

@ag4ums ag4ums Awaiting requested review from ag4ums ag4ums is a code owner

Assignees

@smrutis1 smrutis1

Labels
New-UI Level for the API and UI level changes for the new-ui ready ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(rest): Create new endpoint for schedule CVE and schedule attachment deletion in admin tab.
7 participants
@nikkuma7 @keerthi-bl @smrutis1 @GMishx @heliocastro @ag4ums @rudra-superrr