feat(dashboard): Added code for dashboard #2183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldrin30
force-pushed
the
feat/dashboard
branch
2 times, most recently
from
b5bec6f
to
f6d915a
Compare
ag4ums
added
needs code review
needs general test
ag4ums
requested changes
Mar 26, 2024
| # example, server address and db name should be parametrized, the code | ||
| # reorganized into a single class or function, etc. | ||
| # | ||
| # initial author: [email protected] |
| #Counting total releases | ||
| design_doc = "_design/Release" | ||
| url = f"{design_doc}/_view/all" #Existing view | ||
| result = list(db.view(url)) |
There was a problem hiding this comment.
separate count method and then parse the design docs
| def dbAttachmentConnection(): | ||
| print('\nConnecting to local couchdb stage server....../') | ||
| couch = couchdb.Server("http://localhost:5984/") | ||
| return couch['sw360attachments'] |
There was a problem hiding this comment.
duplication in database connection functions, please define in a single place
| business_unit = doc["value"]["group"] | ||
| length = doc["length"] | ||
| group_info[business_unit]["count"] += 1 | ||
| group_info[business_unit]["total_length"] += length |
There was a problem hiding this comment.
same data iterated over multiple times, please use a function instead
eldrin30
force-pushed
the
feat/dashboard
branch
from
f6d915a
to
6d066cc
Compare
eldrin30
changed the title
eldrin30
force-pushed
the
feat/dashboard
branch
from
6d066cc
to
b562cef
Compare
heliocastro
requested changes
Apr 29, 2024
heliocastro
requested review from
GMishx,
KoukiHama and
arunazhakesan
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a script file which gets back all the required data for dashboard
Following data are fetched
Suggest Reviewer
@ag4ums