fix(rest):new endpoint to delete all license information in admin tab #2060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ag4ums
added
needs code review
needs general test
nikkuma7
force-pushed
the
fix/deletealllicenseinfo
branch
2 times, most recently
from
e184423
to
92e9378
Compare
| @@ -158,4 +158,12 @@ private HalResource<License> createHalLicense(License sw360License) { | |||
| } | |||
| return halLicense; | |||
| } | |||
|
|
|||
| @PreAuthorize("hasAuthority('WRITE')") | |||
| @RequestMapping(value = LICENSES_URL + "/delete", method = RequestMethod.DELETE) | |||
There was a problem hiding this comment.
change the endpoint to /deleteAll.
| import org.eclipse.sw360.datahandler.thrift.SW360Exception; | ||
| import org.eclipse.sw360.datahandler.thrift.licenses.License; | ||
| import org.eclipse.sw360.datahandler.thrift.licenses.Obligation; | ||
| import org.eclipse.sw360.datahandler.thrift.licenses.LicenseService; | ||
| import org.eclipse.sw360.datahandler.thrift.users.User; | ||
| import org.eclipse.sw360.datahandler.thrift.users.UserGroup; | ||
| import org.eclipse.sw360.datahandler.thrift.vendors.Vendor; | ||
| import org.eclipse.sw360.datahandler.thrift.vendors.VendorService; |
There was a problem hiding this comment.
please remove unnecessary imports.
| public void deleteAllLicenseInfo(User user) throws TException { | ||
| LicenseService.Iface sw360LicenseClient = getThriftLicenseClient(); | ||
| if(PermissionUtils.isUserAtLeast(UserGroup.ADMIN, user)){ | ||
| RequestSummary deleteLicenseStatus = sw360LicenseClient.deleteAllLicenseInformation(user); |
There was a problem hiding this comment.
use proper spacing for if condition.
|
While testing one license is not getting deleted. |
nikkuma7
force-pushed
the
fix/deletealllicenseinfo
branch
2 times, most recently
from
dd26c70
to
b5529aa
Compare
|
| public void deleteAllLicenseInfo(User user) throws TException { | ||
| LicenseService.Iface sw360LicenseClient = getThriftLicenseClient(); | ||
| if (PermissionUtils.isUserAtLeast(UserGroup.ADMIN, user)) { | ||
| RequestSummary deleteLicenseStatus = sw360LicenseClient.deleteAllLicenseInformation(user); |
There was a problem hiding this comment.
use proper indentation on line 84
Signed-off-by: Nikesh kumar <[email protected]>
nikkuma7
force-pushed
the
fix/deletealllicenseinfo
branch
from
b5529aa
to
7c8f8d2
Compare
|
code looks good. |
rudra-superrr
added
ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #2064
Create a new rest endpoint to delete all license information in admin tab
Suggest Reviewer
How To Test?
1: http://localhost:8080/resource/api/licenses/delete
2: login with admin user and create token
3: use token in postman.
Checklist
Must: