-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rest): API to get vulnerability tracking status #2014
feat(rest): API to get vulnerability tracking status #2014
Conversation
e003dc0
to
33e3406
Compare
As per the discussion, the response structure has been changed as follows and committed the changes. Sample response : |
21ccf67
to
7853c47
Compare
...c/main/java/org/eclipse/sw360/rest/resourceserver/vulnerability/VulnerabilityController.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/eclipse/sw360/rest/resourceserver/vulnerability/VulnerabilityController.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/eclipse/sw360/rest/resourceserver/vulnerability/VulnerabilityController.java
Show resolved
Hide resolved
...main/java/org/eclipse/sw360/rest/resourceserver/vulnerability/Sw360VulnerabilityService.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/eclipse/sw360/rest/resourceserver/vulnerability/VulnerabilityController.java
Outdated
Show resolved
Hide resolved
885a179
to
2eb2bb0
Compare
Signed-off-by: Keerthi B L <[email protected]> feat(rest): API to get vulnerability tracking status Signed-off-by: Keerthi B L <[email protected]>
96e0f64
to
546e622
Compare
Review comments addressed. |
...c/main/java/org/eclipse/sw360/rest/resourceserver/vulnerability/VulnerabilityController.java
Outdated
Show resolved
Hide resolved
546e622
to
fd92b76
Compare
Review comment addressed. |
@keerthi-bl, the response body doesn't seem to be in JSON type You can try to rewrite the controller like below
|
...c/main/java/org/eclipse/sw360/rest/resourceserver/vulnerability/VulnerabilityController.java
Outdated
Show resolved
Hide resolved
fd92b76
to
9a54c2b
Compare
Review comments addressed. |
...c/main/java/org/eclipse/sw360/rest/resourceserver/vulnerability/VulnerabilityController.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/eclipse/sw360/rest/resourceserver/vulnerability/VulnerabilityController.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/eclipse/sw360/rest/resourceserver/vulnerability/VulnerabilityController.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Keerthi B L <[email protected]>
9a54c2b
to
7014159
Compare
Review comments addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
Suggest Reviewer
How To Test?
End Point : http://localhost:8080/resource/api/vulnerabilities/trackingstatus/8b3aa2f81a764fb482d6391516d153db
Sample Response :
{
"_embedded": {
"sw360:releaseClearingStatusDatas": [
{
"release": {
"type": "release",
"name": "Component2",
"version": "1.0",
"componentId": "cb38c33187934c85a3c024414ff2dd2a",
"releaseDate": "",
"externalIds": {},
"additionalData": {},
"attachments": [
{
"filename": "projects-2023-03-02.xlsx",
"sha1": "349851d0913535925073ca0d34077bd5bd06c002",
"attachmentType": "SOURCE",
"createdBy": "[email protected]",
"createdTeam": "DEPARTMENT",
"createdComment": "",
"createdOn": "2023-06-15",
"checkedComment": "",
"checkStatus": "NOTCHECKED"
}
],
"createdOn": "2023-01-25",
"mainlineState": "OPEN",
"clearingState": "NEW_CLEARING",
"externalToolProcesses": [],
"createdBy": "[email protected]",
"contributors": [],
"subscribers": [],
"roles": {},
"mainLicenseIds": [],
"otherLicenseIds": [],
"vendor": {
"type": "vendor",
"url": "http://localhost:8999",
"shortName": "DV",
"fullName": "Demo Vendor"
},
"languages": [],
"operatingSystems": [
"Linux"
],
"softwarePlatforms": [],
"sourceCodeDownloadurl": "",
"binaryDownloadurl": "",
"externalToolProcessesIterator": [],
"cpeId": "",
"eccInformation": {
"eccStatus": "IN_PROGRESS"
}
},
"componentType": "SERVICE",
"projectNames": "Demo Project (11)",
"mainlineStates": "Open",
"accessible": true,
"setMainlineStates": true,
"setProjectNames": true,
"setComponentType": true,
"setRelease": true,
"setAccessible": true
}
]
},
"_links": {
"curies": [
{
"href": "http://localhost:8080/resource/docs/{rel}.html",
"name": "sw360",
"templated": true
}
]
}
}
Checklist
Must: