-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-4622 SHACL Validation Report preserve blank node IDs with remote repositories #4624
base: main
Are you sure you want to change the base?
Conversation
tools/server-spring/src/main/java/org/eclipse/rdf4j/http/server/ProtocolExceptionResolver.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks technically correct to me, but I'm puzzled by why you'd need blank node preservation here in the first place.
It's normally something that we only use in very specific internal client-server comms use cases (e.g. in supporting remote transactions). I don't think we ever use it (or recommend using it) for somehow allowing a user to reference a bnode by id remotely.
Also: we tend to use RDF Binary everywhere else to support this: why choose RDF/JSON in this case?
I haven't tried using RDF Binary. I'll test it out. The reason I need to preserve blank node identifiers is that this is a transfer of the validation exception from the server to the client. The user would then typically want to find out more about what went wrong by retrieving the full shape from the server. It's common practice to use blank nodes for PropertyShape(s), so that's why we need to preserve the blank node identifiers. |
TODO
|
938a327
to
8865893
Compare
I think that this should be split into two branches. One with a simple fix that just changes out the format to binary, and a second that changes things up a bit by using the http body. The second branch should also bump the protocol version and target the develop branch. |
…mote repository
…lign with how RDF data is typically transmitted over HTTP
8865893
to
5d652ee
Compare
GitHub issue resolved: #4622
Briefly describe the changes proposed in this PR:
PR Author Checklist (see the contributor guidelines for more details):
mvn process-resources
to format from the command line)