Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to cancel if workspace is in use #2628

Open
laeubi opened this issue Dec 14, 2024 · 4 comments
Open

Add a way to cancel if workspace is in use #2628

laeubi opened this issue Dec 14, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@laeubi
Copy link
Contributor

laeubi commented Dec 14, 2024

Currently the user is only offered a way to choose a different location (what also happens on closing the dialog with the usual [x]) or to retry:

grafik

instead there should be an opportunity to cancel the launch (like it is possible on the workspace chooser dialog)

@laeubi laeubi added enhancement New feature or request good first issue Good for newcomers labels Dec 14, 2024
@merks
Copy link
Contributor

merks commented Dec 14, 2024

I'm not saying an explicit button is not a good thing, but I wanted to note that the "x" button and the esc key do that too. 😬

@laeubi
Copy link
Contributor Author

laeubi commented Dec 14, 2024

I'm not saying an explicit button is not a good thing, but I wanted to note that the "x" button and the esc key do that too. 😬

Please try it out, they don't cancel the launch but open the Workspacechooser dialog (as if I have clicked the Choose button) at least on Linux ... (where ESC don't work at all). So one has to dismiss two times if accidentally starting eclipse again.

@merks
Copy link
Contributor

merks commented Dec 14, 2024

That's a good point. One certainly would expect them to NOT do the same thing as Choose!

@HannesWell
Copy link
Member

I'm not saying an explicit button is not a good thing, but I wanted to note that the "x" button and the esc key do that too. 😬

Please try it out, they don't cancel the launch but open the Workspacechooser dialog (as if I have clicked the Choose button) at least on Linux ... (where ESC don't work at all). So one has to dismiss two times if accidentally starting eclipse again.

What about changing the behavior to do that? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants