Adding additional debugging info for UaException in Client

[mrkrizic]

Hi,

I am currently experiencing the issue that a test is failing with the following exception:

status=Bad_NodeIdUnknown, description=The node id refers to a node that does not exist in the server address space.
UaException: status=Bad_NodeIdUnknown, message=The node id refers to a node that does not exist in the server address space.
	at org.eclipse.milo.opcua.sdk.client.AddressSpace.newVariableNode(AddressSpace.java:1341)
	at org.eclipse.milo.opcua.sdk.client.AddressSpace.lambda$getVariableNodeAsync$4(AddressSpace.java:321)
	at java.util.concurrent.CompletableFuture.uniCompose(CompletableFuture.java:966)
	at java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:940)
	at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:488)
	at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1975)
	at org.eclipse.milo.opcua.stack.client.UaStackClient.lambda$deliverResponse$5(UaStackClient.java:309)
	at org.eclipse.milo.opcua.stack.core.util.ExecutionQueue$Task.run(ExecutionQueue.java:119)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

This seems to be caused by the client while reading either a Variable or Calling a method. I am certain the error is on my end and that it will be resolved quickly.

However this will probably not be the last time I face this issue, since it is a common occurence when adding new features. Is it possible to add the server endpoint and the requested NodeId to the Exception?

I was thinking of something along the lines of:

status=Bad_NodeIdUnknown, description=The node id (NodeId("ns=2;s=TestDevice/TestFolder/TestVar") refers to a node that does not exist in the server address space (endpoint=127.0.0.1:4840).
UaException: status=Bad_NodeIdUnknown, message=The node id refers to a node that does not exist in the server address space.
...

Please bear in mind this solution is just a suggestion I came up right now to show what I would consider important to add.

I am not an expert in opcua and would appreciate your view on this matter. Hopefully a feature like this would not cause any incompabilities with the opcua standard or security vulnerabilities.

Any feedback would be appreciated!

[kevinherron]

I understand this is a difficult situation but I'm not sure embedded that kind of information into the exception message is the right move.

Presumably you're the one logging this information, so perhaps you should add that information to your log message. Using something like a Mapped Diagnostics Context with your logging library of choice might be the right move, you can set keys like endpoint-url or server-name or whatever else might be useful to your application.