-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hono Documentation to include Kafka #2601
Comments
Regarding the Getting Started guide: the simplest solution would probably be to make a complete copy of the guide with adaptions to Kafka. The two documents can always be integrated later if it becomes apparent that both variants of messaging should be promoted permanently. WDYT? |
…ing. Signed-off-by: Abel Buechner-Mihaljevic <[email protected]>
#2682 adds this. |
…TLS. Signed-off-by: Abel Buechner-Mihaljevic <[email protected]>
@sophokles73 Maybe I missed something, but I thought both variants actually were supposed to coexist permanently? |
FMPOV there is no reason to discontinue the AMQP support. However, we should still have a preferred setup that we use by default and which we should then also use in the Getting Started guide, right? |
I am not sure now: can we all agree on the proposal to create two separate documents? I think there needs to be some sort of end-to-end documentation for each type of messaging system that shows how to use the overall system with clients. The existing Getting Started Guide FMPOV does a great job at this. The differences between AMQP-based and Kafka-based messaging are significant enough that I think it makes sense to have two separate documents for them. |
If the documents do differ significantly there's no reason not to have them 😃 Maybe I misunderstood what you wrote. I got the impression the argument was to have a (mostly) duplicated copy for now and postpone the effort for integrating both documents later, since the assumption was that one copy may become obsolete... |
…ing. Signed-off-by: Abel Buechner-Mihaljevic <[email protected]>
…TLS. Signed-off-by: Abel Buechner-Mihaljevic <[email protected]>
The external Kafka port used by the Hono Helm chart has been changed from 9094 to 9092. This adapts the Kafka messaging guide accordingly. Signed-off-by: Abel Buechner-Mihaljevic <[email protected]>
…ing guide. Signed-off-by: Abel Buechner-Mihaljevic <[email protected]>
Added a separate Getting Started guide to the home page based on Kafka based messaging instead of the default AMQP 1.0 based messaging. Signed-off-by: Abel Buechner-Mihaljevic <[email protected]>
FMPOV, yes. |
With the upcoming Kafka support the Hono documentation should be adapted, e.g. the CLI documentation, Getting Started and all other places where the messaging network is used.
The text was updated successfully, but these errors were encountered: