Jersey core client 3.1.9 memory leak

[jonkjenn]

If I'm not missing something this is a memory leak if you target unique URLs.

jersey/core-client/src/main/java/org/glassfish/jersey/client/HttpUrlConnectorProvider.java

Line 301 in f35691f

private final ConcurrentHashMap<URL, Lock> locks = new ConcurrentHashMap<>();

[MarioSob]

This is indeed a memory leak. This map can only increase in size.

I suggest this class to take the following shape:

private static class DefaultConnectionFactory implements ConnectionFactory {
    private final ConcurrentHashMap<URL, Semaphore> locks = new ConcurrentHashMap<>();

    @Override
    public HttpURLConnection getConnection(URL url) throws IOException {
        return connect(url, null);
    }

    @Override
    public HttpURLConnection getConnection(URL url, Proxy proxy) throws IOException {
        return connect(url, proxy);
    }

    private HttpURLConnection connect(URL url, Proxy proxy) throws IOException {
        Semaphore thisThreadLock = new Semaphore(0);
        Semaphore previousThreadLock = locks.putIfAbsent(url, thisThreadLock);
        try {
            if (previousThreadLock != null) {
                previousThreadLock.acquireUninterruptibly();
            }
            return proxy == null
                    ? (HttpURLConnection) url.openConnection()
                    : (HttpURLConnection) url.openConnection(proxy);
        } finally {
            locks.remove(url, thisThreadLock);
            thisThreadLock.release();
        }
    }
}

[jansupol]

Thank you for reporting this. We have a fix in progress: #5794