Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: how to start with it? #4

Open
kbachl opened this issue May 8, 2023 · 8 comments
Open

Question: how to start with it? #4

kbachl opened this issue May 8, 2023 · 8 comments

Comments

@kbachl
Copy link

kbachl commented May 8, 2023

I hope its ok to use the tracker, but I've read about this on reddit nearly 3 weeks ago and find it very interesting. However, I've not seen any documentation or examples...

Is there anywhere some kind of tutorial how to start "from scratch" for a typical project?

e.g.: config for a deployment of a webapp on a certain path, setting master password, DB access via JNDI and cluster etc.?

@dmatej
Copy link
Contributor

dmatej commented May 9, 2023

Basically it is similar like running the virtual machine. You can create your own image based on this with prepared domain. Or you can use asadmin to change the configuration on the running docker.

Some really basic documentation for the docker image is here:
https://github.com/OmniFish-EE/docker-library-docs/blob/glassfish/glassfish/content.md

It is a part of the GlassFish PR to standard docker images. We plan to extend it more, but it will take some time.

@chabala
Copy link

chabala commented May 10, 2023

This could use some further elaboration, especially in the push to make this the official docker image. For instance, the examples on the readme:

Links to examples will be added soon ...

That's really not enough to get started.

  • How can one deploy an app?
  • Can it be used as a base image?
  • Can the image be used from docker compose?
  • Can I mount volumes to:
    • change configuration?
    • install apps?
    • persist deployment information?

Should have more of these questions answered upfront. Look at Bitnami's WildFly image for inspiration.

@OndroMih
Copy link
Contributor

As a start, you can follow the documentation here, and even directly use the Docker images built by OmniFish: https://hub.docker.com/r/omnifish/glassfish

@chabala
Copy link

chabala commented May 29, 2023

As a start, you can follow the documentation here, and even directly use the Docker images built by OmniFish: https://hub.docker.com/r/omnifish/glassfish

Okay, where did those images get built from? Because that documentation isn't present in OmniFish-EE/docker-library-glassfish. Transparency is important here.

@OndroMih
Copy link
Contributor

Those images are built from this repository. But I update the documentation manually directly in DockerHub.and forgot to update the documentation in the source repo. We're now migrating this repository to the Eclipse Foundation, we'll update the docs the git repository once it's at the Eclipse Foundation.

@dmatej
Copy link
Contributor

dmatej commented Sep 2, 2024

@chabala
Copy link

chabala commented Sep 2, 2024

This link is pretty good: https://github.com/eclipse-ee4j/glassfish.docker/wiki/Example:-Using-docker-Command

I'd like to see a docker-compose example as well.

If this is hosted on DockerHub, I'd want to see this level of detail on the README, so it would show up on the hub page. This is key information to using the image.

Again, compare with the Bitnami WildFly image documentation. Look at all those ENV variables. Can I set GLASSFISH_USERNAME in docker compose to change the admin user? Wildfly supports that with WILDFLY_USERNAME. Those are the kinds of questions potential end users will have. People will want to be able to configure the app at docker image build time, not just log in to the admin console after it's up.

@dmatej
Copy link
Contributor

dmatej commented Nov 24, 2024

Recently we added also more useful example for TestContainers: https://github.com/eclipse-ee4j/glassfish.docker/wiki/Example:-TestContainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants