Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for bluechi-is-online node without any cli options #982

Closed
Tracked by #977
engelmi opened this issue Nov 11, 2024 · 1 comment · Fixed by #999
Closed
Tracked by #977

Add integration tests for bluechi-is-online node without any cli options #982

engelmi opened this issue Nov 11, 2024 · 1 comment · Fixed by #999
Assignees
@nsimsolo
Labels
enhancement New feature or request jira Issues that are synced to Jira testing This issue adds or improves the testing
Milestone
v0.10

Comments

@engelmi
Copy link
Member

engelmi commented Nov 11, 2024 •
edited
Loading

Please describe what you would like to see

In #962 the new package bluechi-is-online was introduced. However, adding integration tests was postponed.

A basic integration test for bluechi-is-online node <nodename> would verify that:

  • it exists with code 1 when the respective node is not connected
  • it exits with code 0 when the respective node is connected


Tech hints

  • bluechi-is-online needs to run on the controller node
  • bluechi-is-online can be wrapped in a systemd unit and check the unit state inactive/failed (see the docs)
@engelmi engelmi mentioned this issue Nov 11, 2024
Open
17 tasks
@engelmi engelmi changed the title without any cli options Add integration tests for bluechi-is-online node without any cli options #981 Nov 11, 2024
@engelmi engelmi added enhancement New feature or request testing This issue adds or improves the testing labels Nov 11, 2024
@engelmi engelmi added this to the v0.10 milestone Nov 11, 2024
@mwperina mwperina changed the title Add integration tests for bluechi-is-online node without any cli options #981 Add integration tests for bluechi-is-online node without any cli options Nov 11, 2024
@nsimsolo
Copy link
Contributor

Please assign this ticket to me

@mwperina mwperina added the jira Issues that are synced to Jira label Nov 11, 2024
@nsimsolo nsimsolo mentioned this issue Dec 4, 2024
Merged
nsimsolo added a commit to nsimsolo/bluechi that referenced this issue Dec 5, 2024
@nsimsolo
Add bluechi_is_online node module and integration test
1142b47 
- Update .gitignore to ignore .idea and inpectionProfiles
- Adding test for bluechi-is-online node.
  'bluechi-is-online node' command is verifying on the controller
  machine (check and/or monitor) the connection of the given node
  to the controller
  When the node is online, it exits with a status code 0
  and does not produce any CLI output.

Fixes: eclipse-bluechi#982
Signed-off-by: nsimsolo <[email protected]>
mwperina pushed a commit to nsimsolo/bluechi that referenced this issue Dec 5, 2024
@nsimsolo @mwperina
Add bluechi_is_online node module and integration test
6f67470 
- Update .gitignore to ignore .idea and inpectionProfiles
- Adding test for bluechi-is-online node.
  'bluechi-is-online node' command is verifying on the controller
  machine (check and/or monitor) the connection of the given node
  to the controller
  When the node is online, it exits with a status code 0
  and does not produce any CLI output.

Fixes: eclipse-bluechi#982
Signed-off-by: nsimsolo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nsimsolo nsimsolo

Labels
enhancement New feature or request jira Issues that are synced to Jira testing This issue adds or improves the testing
Projects
None yet
Milestone
v0.10
Development

Successfully merging a pull request may close this issue.

Add bluechi_is_online node module and integration test nsimsolo/bluechi
3 participants
@mwperina @nsimsolo @engelmi