Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aasx: Add failsafe for writing and reading AASX files #228

Open
WelliSolutions opened this issue Jan 23, 2024 · 1 comment
Open

aasx: Add failsafe for writing and reading AASX files #228

WelliSolutions opened this issue Jan 23, 2024 · 1 comment
Labels
enhancement Enhancement of an existing feature sdk Something to do with the `sdk` package

Comments

@WelliSolutions
Copy link

You kindly told me about the failsafe parameter at the read_into() method.

I was now trying to write an AASX file which should have had an attachment, but doesn't. When writing the AASX file, an error message is printed, but no exception occurs.

The message is

Could not find file /aasx/files/file.txt in file store.

I'd rather have my program crash, so that the problem gets reported and fixed, rather than creating an invalid AASX file which may remain unnoticed for a long time. I tried failsafe=False as an additional parameter, but it seems that doesn't exist.

If no such feature exists, I'd like to request that.

@s-heppner
Copy link
Contributor

I just checked our AASXWriter implementation and you're correct, there is no failsafe parameter implemented.
I think it's a good addition, I'll adapt your issue and make a feature request out of it.

@s-heppner s-heppner added the enhancement Enhancement of an existing feature label Jan 24, 2024
@s-heppner s-heppner changed the title Is there a failsafe-like way of writing AASX files? aasx: Add failsafe for writing and reading AASX files Jan 24, 2024
@s-heppner s-heppner added the sdk Something to do with the `sdk` package label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of an existing feature sdk Something to do with the `sdk` package
Projects
None yet
Development

No branches or pull requests

2 participants