From 39c1eed235b3044e193305847cb8f30484e80207 Mon Sep 17 00:00:00 2001 From: haschek Date: Mon, 13 Nov 2023 11:17:37 +0000 Subject: [PATCH 1/8] Prepare release v23.3.1 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index fb2685db..9b5176fb 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "@eccenca/gui-elements", "description": "GUI elements based on other libraries, usable in React application, written in Typescript.", - "version": "23.3.0", + "version": "23.3.1-rc.0", "license": "Apache-2.0", "homepage": "https://github.com/eccenca/gui-elements", "bugs": "https://github.com/eccenca/gui-elements/issues", From ce9d382888930ec97d06e560500ed5d3b4fe5e38 Mon Sep 17 00:00:00 2001 From: Michael Haschke Date: Mon, 13 Nov 2023 12:25:05 +0100 Subject: [PATCH 2/8] remove always white space at start of portalClassName --- CHANGELOG.md | 5 +++++ src/components/ContextOverlay/ContextOverlay.tsx | 9 +++++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4dab2739..a2c93202 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p ## [Unreleased] +### Fixed + +- `` + - remove always white space at start of `portalClassName` to prevent runtime error in BlueprintJS + ## [23.3.0] - 2023-11-09 ### Added diff --git a/src/components/ContextOverlay/ContextOverlay.tsx b/src/components/ContextOverlay/ContextOverlay.tsx index ac5aa1a7..35544eca 100644 --- a/src/components/ContextOverlay/ContextOverlay.tsx +++ b/src/components/ContextOverlay/ContextOverlay.tsx @@ -26,15 +26,16 @@ export const ContextOverlay = ({ className = "", ...restProps }: ContextOverlayProps) => { + const portalClassNameFinal = + (preventTopPosition ? `${eccgui}-contextoverlay__portal--lowertop` : "") + + (portalClassName ? ` ${portalClassName}` : ""); + return ( {children} From 2dc101981b0bea781c3e1e88d4cfcde6553f739f Mon Sep 17 00:00:00 2001 From: haschek Date: Mon, 13 Nov 2023 11:58:58 +0000 Subject: [PATCH 3/8] Bump release version to next release candidate 23.3.1-rc.1 --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 9b5176fb..f3626da6 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "@eccenca/gui-elements", "description": "GUI elements based on other libraries, usable in React application, written in Typescript.", - "version": "23.3.1-rc.0", + "version": "23.3.1-rc.1", "license": "Apache-2.0", "homepage": "https://github.com/eccenca/gui-elements", "bugs": "https://github.com/eccenca/gui-elements/issues", From 80e5da5e9a30fd28f176bee99ea3b9eed8bbf53a Mon Sep 17 00:00:00 2001 From: Michael Haschke Date: Wed, 15 Nov 2023 14:41:25 +0100 Subject: [PATCH 4/8] request checks in commit message for release candidate --- .github/workflows/release-candidate.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-candidate.yml b/.github/workflows/release-candidate.yml index e9fc92bc..2b48e580 100644 --- a/.github/workflows/release-candidate.yml +++ b/.github/workflows/release-candidate.yml @@ -51,7 +51,7 @@ jobs: - name: Bump release candidate version in package.json run: | yarn version --no-git-tag-version --preid "rc" --prerelease - git commit package.json --message "Bump release version to next release candidate $(node -p -e "require('./package.json').version")" + git commit package.json --message "Bump release version to next release candidate $(node -p -e "require('./package.json').version")\n\n\nrequest-checks: true" - name: Push tag and changes run: | git push From 293b156708084b9be3d4d6944389ad8975ae896b Mon Sep 17 00:00:00 2001 From: haschek Date: Wed, 15 Nov 2023 14:15:02 +0000 Subject: [PATCH 5/8] Bump release version to next release candidate 23.3.1-rc.2\n\n\nrequest-checks: true --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index f3626da6..cc003a14 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "@eccenca/gui-elements", "description": "GUI elements based on other libraries, usable in React application, written in Typescript.", - "version": "23.3.1-rc.1", + "version": "23.3.1-rc.2", "license": "Apache-2.0", "homepage": "https://github.com/eccenca/gui-elements", "bugs": "https://github.com/eccenca/gui-elements/issues", From 9c3e7e66047c38fa1e3f44fd64dd226fec2e34cb Mon Sep 17 00:00:00 2001 From: Michael Haschke Date: Wed, 15 Nov 2023 15:31:14 +0100 Subject: [PATCH 6/8] fix message syntax --- .github/workflows/release-candidate.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-candidate.yml b/.github/workflows/release-candidate.yml index 2b48e580..65113271 100644 --- a/.github/workflows/release-candidate.yml +++ b/.github/workflows/release-candidate.yml @@ -51,7 +51,7 @@ jobs: - name: Bump release candidate version in package.json run: | yarn version --no-git-tag-version --preid "rc" --prerelease - git commit package.json --message "Bump release version to next release candidate $(node -p -e "require('./package.json').version")\n\n\nrequest-checks: true" + git commit package.json --message "Bump release version to next release candidate $(node -p -e "require('./package.json').version")"$'\n\n\n'"request-checks: true" - name: Push tag and changes run: | git push From e9333fb32c32a0f93ea743cfe4561d5aded60f64 Mon Sep 17 00:00:00 2001 From: haschek Date: Wed, 15 Nov 2023 14:38:46 +0000 Subject: [PATCH 7/8] Bump release version to next release candidate 23.3.1-rc.3 request-checks: true --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index cc003a14..6dbeb1cd 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "@eccenca/gui-elements", "description": "GUI elements based on other libraries, usable in React application, written in Typescript.", - "version": "23.3.1-rc.2", + "version": "23.3.1-rc.3", "license": "Apache-2.0", "homepage": "https://github.com/eccenca/gui-elements", "bugs": "https://github.com/eccenca/gui-elements/issues", From e81eb11741e95033828934cd6762c69546e5dd59 Mon Sep 17 00:00:00 2001 From: Michael Haschke Date: Wed, 15 Nov 2023 15:57:15 +0100 Subject: [PATCH 8/8] remove the check request as github seems to ignore it --- .github/workflows/release-candidate.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-candidate.yml b/.github/workflows/release-candidate.yml index 65113271..e9fc92bc 100644 --- a/.github/workflows/release-candidate.yml +++ b/.github/workflows/release-candidate.yml @@ -51,7 +51,7 @@ jobs: - name: Bump release candidate version in package.json run: | yarn version --no-git-tag-version --preid "rc" --prerelease - git commit package.json --message "Bump release version to next release candidate $(node -p -e "require('./package.json').version")"$'\n\n\n'"request-checks: true" + git commit package.json --message "Bump release version to next release candidate $(node -p -e "require('./package.json').version")" - name: Push tag and changes run: | git push