-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate PDFs on CI #274
Merged
Merged
Generate PDFs on CI #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and don't insert a period in place of it in the descriptive version strings
This allows for testing of the setup application without needed packaging
…te into translocation-fix
Like you said, would be good to squash the changes to a single commit, but otherwise looks great & much easier than running things manually. |
rsjbailey
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates the package documents on the CI rather than having to be a manual step done locally. Note that manual generation hasn't been messed with so is still an option.
Uses cmake to generate README.md from README.in.md, then uses an existing github action to generate PDFs from both the LICENSE.md and README.md files. This also seems to create nicer looking docs by default than the existing pandoc process, Note this action only runs on linux so it's run as a common job for all platform-specific builds before those build jobs are fired off.
History is messy so needs squashing before merging.