Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema update priority ticket - gender/Visium 2022-07-05 #844

Open
Wkt8 opened this issue Jul 5, 2022 · 15 comments
Open

Schema update priority ticket - gender/Visium 2022-07-05 #844

Wkt8 opened this issue Jul 5, 2022 · 15 comments
Assignees
Labels
HCA operations This issue is an operational task

Comments

@Wkt8
Copy link
Collaborator

Wkt8 commented Jul 5, 2022

What are the next schema updates?
Schema Update 1: Gender field
PR here
Schema Update 2: Visium permeabilisation time field
PR here

What schemas will they affect?
These changes will affect the following schemas:

  • type/biomaterial/donor_organism.json
  • module/ontology/gender_identity.json
  • type/protocol/imaging/imaging_preparation_protocol.json

Why are these changes needed?
We currently lack the metadata field to store gender. There are datasets with trans donors (TestisCellAtlas) where gathering and storing this metadata is vital. The dataset is blocked by this. This schema change adds an optional ontologised gender field to donor_organism.

Data contributors want to be able to store the permeabilisation time field in our metadata schema as it is a key field that they want to search and filter through.

Type of change and time frame
Update number 1 constitutes a minor change.
Update number 2 constitutes a minor change.

We are expecting to push both updates before 20/07/2022 (Wednesday, 20th July)

@Wkt8 Wkt8 added next to be worked on next operations This issue is an operational task labels Jul 5, 2022
@ESapenaVentura ESapenaVentura self-assigned this Jul 6, 2022
@ESapenaVentura
Copy link
Collaborator

Enrique to check the PRs for the comments

@Wkt8
Copy link
Collaborator Author

Wkt8 commented Aug 1, 2022

Gender field PR is waiting on the ontology release
Visium permeabilisation time PR is waiting on Hannes to reply to Ida's comments

@MightyAx
Copy link
Contributor

@ESapenaVentura to check if review has gone through today.

@ESapenaVentura
Copy link
Collaborator

Gender_identity is ready, waiting on ontology ticket
Visium permeabilisation field will be merged by EOD wednesday

@ESapenaVentura
Copy link
Collaborator

EOD friday as hannes is on holidays

@gabsie gabsie changed the title Schema update priority ticket - 2022-07-05 Schema update priority ticket - gender/Visium 2022-07-05 Aug 16, 2022
@idazucchi idazucchi added the externally blocked Issue blocked by something outside DCP label Aug 16, 2022
@gabsie
Copy link

gabsie commented Aug 19, 2022

The Visium update will be merged, as approved by Hannes.

@idazucchi idazucchi added needs ontology term dataset is waiting for export until new ontology term is released and removed next to be worked on next externally blocked Issue blocked by something outside DCP labels Sep 27, 2022
@ESapenaVentura ESapenaVentura removed the needs ontology term dataset is waiting for export until new ontology term is released label Nov 10, 2022
@ESapenaVentura
Copy link
Collaborator

This will be included in the next ontology release

@ESapenaVentura
Copy link
Collaborator

Ontology release to staging has been done - I am pushing the PR to staging

@idazucchi
Copy link
Collaborator

enrique is investigating the linter faliure in the schema repo

@ESapenaVentura
Copy link
Collaborator

@ESapenaVentura chatted with Zoe about the issue - Created ticket in HCAO repo

@Wkt8
Copy link
Collaborator Author

Wkt8 commented Nov 22, 2022

Stalled until we hear back about gender_identity ontology term.

@ESapenaVentura
Copy link
Collaborator

Still not solved with this month's release...

@ESapenaVentura
Copy link
Collaborator

Had a discussion with Zoe, they couldn't get to fix the issue and will work on it for the next release!

@gabsie
Copy link

gabsie commented Jan 19, 2023

The gender_identity ontology term needs a meeting setup with OLS. @ESapenaVentura to action this.

@ESapenaVentura
Copy link
Collaborator

ESapenaVentura commented Jan 23, 2023

I have sent an email to Henriette, copying in CC Zoe and the wrangler team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HCA operations This issue is an operational task
Projects
None yet
Development

No branches or pull requests

5 participants