Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic user_friendly name in generated spreadsheets #977

Open
2 of 7 tasks
arschat opened this issue Aug 23, 2023 · 1 comment
Open
2 of 7 tasks

Generic user_friendly name in generated spreadsheets #977

arschat opened this issue Aug 23, 2023 · 1 comment
Assignees

Comments

@arschat
Copy link

arschat commented Aug 23, 2023

Describe the bug
When I download a generated spreadsheet from DCP the user_friendly names I get for all biomaterials and protocols is a generic Biomaterial ID and Protocol ID instead of DONOR ORGANISM ID and COLLECTION PROTOCOL ID I have from the template that we use.
There can be multiple columns with the same name when we have input biomaterial into one entity or multiple protocols applied to one entity.

To Reproduce

  1. Download a spreadsheet from DCP i.e. GSE67833_neural_stem_cells (works for ~100 spreadsheets I downloaded).
  2. For each tab of the graph for biomaterial or protocol, the user_friendly name is a generic Biomaterial ID or Protocol ID

Expected behaviour
The generated spreadsheet would have a user_friendly name for the Biomaterial ID that specifies the type of biomaterial i.e. Donor Organism ID, Specimen from Organism ID, Cell suspension ID, Cell line ID, Organoid ID, Imaged specimen ID and the type of protocol Aggregate generation protocol, Collection protocol, Differentiation protocol, Dissociation protocol, Enrichment protocol, iPSC induction protocol, Treatment protocol, Imaging preparation protocol, Imaging Protocol, Library preparation protocol, Sequencing protocol, Analysis protocol.

Screenshots / Logs
What is shown in the downloaded spreadsheet from DCP.
Private Zenhub Image

What is shown in the template that we use.
Private Zenhub Image

Links
no links

Environment

  • prod
  • staging
  • dev

Browser

  • Chrome
  • Safari
  • IE
  • Other (please specify)
@ESapenaVentura ESapenaVentura self-assigned this Aug 24, 2023
@ESapenaVentura
Copy link

I investigated a bit about this, this is due to the way the flattener recollects the information from the schemas for the headers.

I am preparing a PR to solve this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants