-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R^2 measures decomposition? #379
Comments
Related. easystats/parameters#479 |
Acknowledging @bwiernik 's concern about importance metrics and their use- and situation-specific interpretation, if the Technically, The package I humbly offer for consideration is still very much in development but, if interested, would be happy to collaborate with the authors here to pull/wrap it in and add needed caveats to contextualize the kinds of insights it may provide for the user by way of the insights it adds about the model's results. |
I would love to have dominance functions in performance! Wrappers for your package would be great |
Pleased to hear it! Look forward to collaborating to bring this in - will start on a fork |
That sounds great indeed :) Looking forward to that! From a design standpoint, I don't know what you have in mind for bringing closer together easystats and domir, however since your package looks to be already functional and well documented, I could imagine several possible scenarios:
Perhaps it's still a bit too soon to talk about how to actually integrate stuff, so no worries if you prefer to be on a "we'll see how it goes" line |
Good question and have been putting some thought into this. My initial thought was probably most similar to the first scenario - but, agreed, may make more sense as the integration proceeds to shift to a more transposed or "absorptive" approach depending on the details 😃. Moving forward, if I have development or design questions I'd like your collective input on, would you all prefer to continue discussion of such questions in this issue thread? |
Sure this thread is a good spot |
Hi All, Have a candidate initial version of a dominance analysis function that I could initiate as a pull request but thought might be better to discuss here first to refine as needed. The repo I'm referring to throughout is: https://github.com/jluchman/performance The added function is called Notes/Comments
Those supported mostly those that have a single outcome and one predictive equation (e.g.,
The current build does not allow for groups of (i.e., like Owen decomposition;
No in-formula offsets, interactions, or transformations (e.g.,
Have also added tests, a print method, and adjusted the spelling document for new words. Have been able to get all automated checks, that are affected by the additions, to pass based on what I'm seeing on GitHub Actions. Also plan to add an argument that a user could supply to Again, happy to initiate a pull request, respond to comments, and implement requested edits prior to a pull request as needed. Looking forward to starting to get this function build into |
Sure, why don't you open a pull request and I can look at it and comment ? |
Happy to and will do shortly. |
There are several packages out there, like
rego
for Stata that provide a Shapley/Owen decomposition for R^2 and R^2 types (adjusted etc.) goodness-of-fit measures.See this paper for example:
https://projecteuclid.org/journals/electronic-journal-of-statistics/volume-6/issue-none/Axiomatic-arguments-for-decomposing-goodness-of-fit-according-to-Shapley/10.1214/12-EJS710.full
and rego package page:
http://www.marco-sunder.de/stata/rego.html
The text was updated successfully, but these errors were encountered: