From ee8c6033549207051e05b5e7f8d63dcda0e9a28a Mon Sep 17 00:00:00 2001
From: Daniel <mail@danielluedecke.de>
Date: Sat, 18 May 2024 12:00:59 +0200
Subject: [PATCH] Fix lintrs, no group_by issues (#970)

* Fix lintrs, no group_by issues

* use insight remotes
---
 DESCRIPTION          |  3 +-
 R/equivalence_test.R | 78 +++++++-------------------------------------
 2 files changed, 14 insertions(+), 67 deletions(-)

diff --git a/DESCRIPTION b/DESCRIPTION
index fc22b094a..7531f36a9 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -1,7 +1,7 @@
 Type: Package
 Package: parameters
 Title: Processing of Model Parameters
-Version: 0.21.7
+Version: 0.21.7.1
 Authors@R:
     c(person(given = "Daniel",
              family = "Lüdecke",
@@ -218,3 +218,4 @@ Config/Needs/website:
     r-lib/pkgdown,
     easystats/easystatstemplate
 Config/rcmdcheck/ignore-inconsequential-notes: true
+Remotes: easystats/insight
diff --git a/R/equivalence_test.R b/R/equivalence_test.R
index 6f26f60b0..1f5c9cab0 100644
--- a/R/equivalence_test.R
+++ b/R/equivalence_test.R
@@ -493,7 +493,7 @@ equivalence_test.ggeffects <- function(x,
 
   out <- do.call(rbind, lapply(names(params), function(np) {
     est <- params[[np]][, "(Intercept)"]
-    stderr <- se[[np]][, "(Intercept)"]
+    std_err <- se[[np]][, "(Intercept)"]
 
     d <- data.frame(
       Parameter = rownames(params[[np]]),
@@ -504,13 +504,13 @@ equivalence_test.ggeffects <- function(x,
     )
 
     conf_int <- as.data.frame(t(data.frame(
-      CI_low = est - stderr * fac,
-      CI_high = est + stderr * fac
+      CI_low = est - std_err * fac,
+      CI_high = est + std_err * fac
     )))
 
     conf_int2 <- as.data.frame(t(data.frame(
-      CI_low = est - stderr * fac_narrow,
-      CI_high = est + stderr * fac_narrow
+      CI_low = est - std_err * fac_narrow,
+      CI_high = est + std_err * fac_narrow
     )))
 
     l <- Map(
@@ -568,13 +568,11 @@ equivalence_test.ggeffects <- function(x,
         decision <- "Rejected"
       }
       # non-significant results
-    } else {
+    } else if (min(abs(ci_narrow)) < max(abs(range_rope)) && max(abs(ci_narrow)) < max(abs(range_rope))) {
       # check if CI are entirely inside ROPE. If CI crosses ROPE, reject H0, else accept
-      if (min(abs(ci_narrow)) < max(abs(range_rope)) && max(abs(ci_narrow)) < max(abs(range_rope))) {
-        decision <- "Accepted"
-      } else {
-        decision <- "Undecided"
-      }
+      decision <- "Accepted"
+    } else {
+      decision <- "Undecided"
     }
   }
 
@@ -663,7 +661,7 @@ equivalence_test.ggeffects <- function(x,
       params <- insight::get_parameters(model)
 
       # degrees of freedom
-      df <- degrees_of_freedom(model, method = "any")
+      dof <- degrees_of_freedom(model, method = "any")
 
       # mu
       params$mu <- params$Estimate * -1
@@ -671,8 +669,8 @@ equivalence_test.ggeffects <- function(x,
       # se
       se <- standard_error(model)
 
-      stats::pt((range[1] - params$mu) / se$SE, df, lower.tail = TRUE) +
-        stats::pt((range[2] - params$mu) / se$SE, df, lower.tail = FALSE)
+      stats::pt((range[1] - params$mu) / se$SE, df = dof, lower.tail = TRUE) +
+        stats::pt((range[2] - params$mu) / se$SE, df = dof, lower.tail = FALSE)
     },
     error = function(e) {
       NULL
@@ -788,55 +786,3 @@ plot.equivalence_test_lm <- function(x, ...) {
   insight::check_if_installed("see")
   NextMethod()
 }
-#'
-#'
-#' #' @export
-#' print_md.equivalence_test_lm <- function(x,
-#'                                          digits = 2,
-#'                                          ci_digits = digits,
-#'                                          p_digits = 3,
-#'                                          ci_brackets = NULL,
-#'                                          zap_small = FALSE,
-#'                                          ...) {
-#'   orig_x <- x
-#'
-#'   rule <- attributes(x)$rule
-#'   if (!is.null(rule)) {
-#'     if (rule == "cet") {
-#'       title <- "Conditional Equivalence Testing"
-#'     } else if (rule == "classic") {
-#'       title <- "TOST-test for Practical Equivalence"
-#'     } else {
-#'       title <- "Test for Practical Equivalence"
-#'     }
-#'   } else {
-#'     title <- "Test for Practical Equivalence"
-#'   }
-#'
-#'   .rope <- attr(x, "rope", exact = TRUE)
-#'   subtitle <- sprintf("  ROPE: [%.*f %.*f]\n\n", digits, .rope[1], digits, .rope[2])
-#'
-#'   # formatting
-#'   x <- format(x,
-#'               digits = digits,
-#'               ci_digits = ci_digits,
-#'               p_digits = p_digits,
-#'               ci_width = NULL,
-#'               ci_brackets = ci_brackets,
-#'               format = "md",
-#'               zap_small = zap_small,
-#'               ...)
-#'
-#'   if ("Group" %in% colnames(x)) {
-#'     group_by <- "Group"
-#'   } else {
-#'     group_by <- NULL
-#'   }
-#'
-#'   cat(insight::export_table(x,
-#'                             format = "md",
-#'                             title = title,
-#'                             subtitle = subtitle,
-#'                             group_by = group_by))
-#'   invisible(orig_x)
-#' }