Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing CRAN checks for recent submission (0.11.0) #511

Closed
strengejacke opened this issue Jun 6, 2024 · 11 comments · Fixed by #513
Closed

Failing CRAN checks for recent submission (0.11.0) #511

strengejacke opened this issue Jun 6, 2024 · 11 comments · Fixed by #513
Assignees

Comments

@strengejacke
Copy link
Member

For old-rel: https://cran.r-project.org/web/checks/check_results_datawizard.html

  Errors in running code in vignettes:
  when running code in ‘tidyverse_translation.Rmd’
    ...
  +     FUN.VALUE = logical(1)))) {
  +     evaluate_chunk <- FALSE
  + }
  
  > starwars %>% data_filter(skin_color == "light", eye_color == 
  +     "brown")
  
    When sourcing ‘tidyverse_translation.R’:
  Error: could not find function "%>%"
  Execution halted

Not sure, why.

@strengejacke
Copy link
Member Author

We could probably have all vignettes only on our website, not on CRAN.

@etiennebacher
Copy link
Member

Seems to me that this is a spurious error, and I didn't get any email from CRAN about this. I'd say let's wait to see if it's solved automatically or if I get some message before making vignettes less available?

@IndrajeetPatil
Copy link
Member

I think this can be closed?

@etiennebacher
Copy link
Member

Yes, I'll reopen if I get some message from CRAN

@etiennebacher etiennebacher closed this as not planned Won't fix, can't repro, duplicate, stale Jun 21, 2024
@strengejacke
Copy link
Member Author

We could still continue with #513 and replace the magrittr pipe with the native pipe (which I personally would prefer).

@IndrajeetPatil
Copy link
Member

This is still present with the latest release: https://cloud.r-project.org/web/checks/check_results_datawizard.html

@etiennebacher
Copy link
Member

Which latest release? datawizard didn't get an update since this issue was open

@strengejacke
Copy link
Member Author

I wonder why the CRAN issues aren't resolved yet. It's still the two failing checks due to the pipe. I'm still pro #513 :-)

etiennebacher pushed a commit that referenced this issue Jul 8, 2024
* Failing CRAN checks for recent submission (0.11.0)
Fixes #511

* 4.1

* Add note
@etiennebacher
Copy link
Member

Should I resubmit? I doubt this is urgent since I didn't get any notice from CRAN, so I think we have time if you want to add more things before the next release

@strengejacke
Copy link
Member Author

Yes, I too think that this is not urgent. It's just a bit "annoying" that we have the CRAN failures across all our packages that depend on datawizard. And related to this, we don't have binaries for Mac OS X old-rel on CRAN - but... I don't care about OS X anyway, so I leave the decision up to you ;-)

@etiennebacher
Copy link
Member

I didn't notice that this prevented the distribution of binaries for 0.11.0, that's annoying. I'll release 0.12.0 this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants