-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-rename change_code()
?
#233
Comments
The "code" being the mapping of quantities to values/labels. So the function is changing the coding scheme used. Maybe Originally posted by @bwiernik in #87 (comment) |
I like |
recode_values() +1 |
@strengejacke I don't think this is low priority. We need to finish renaming in as few release cycles as possible. We can't keep changing function names every time we update the package; it doesn't reflect well on us. I would like to be done with renaming for the existing functions in the next ( |
ok, than let's go for |
In the future, if there are lingering concerns about renaming a function or argument, I'd like to not merge or at least not release until there is consensus. Eg, we probably should have left |
Closes #233 Co-authored-by: Daniel <[email protected]>
Before we finalize this, we should definitely decide on the new function names. Mostly, I'm not quite satisfied with
change_code()
.recode
is a verb, and everyone would expect such a function would recode old into new values. inchange_code()
, the verb ischange
, and what can we expect if we change a code? What we actually change when recoding are values (or factor levels, but values is maybe more generic). What do you think aboutchange_values()
? or mayberecode_values()
, orrecode_variables()
.Originally posted by @strengejacke in #87 (comment)
The text was updated successfully, but these errors were encountered: