Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROJECT] Future Maintenance of this Project #143

Open
Zjjc123 opened this issue May 2, 2021 · 14 comments
Open

[PROJECT] Future Maintenance of this Project #143

Zjjc123 opened this issue May 2, 2021 · 14 comments
Assignees
Labels
help wanted Extra attention is needed important Top priority question Further information is requested

Comments

@Zjjc123
Copy link
Member

Zjjc123 commented May 2, 2021

The Issue

This repository was started by me (current EHS Key Club Community Service Manager) and my friend @daniel-sudz (react genius). This website is used by Key Club but it is also used by the PTSA (therefore the entire Eastlake High School).

But we are both seniors and will be heading to college. This means

  1. We won't have time to maintain and improve this as much.
  2. It isn't sustainable for us to do so.

Further Issue

I was also busy during the Key Club Officer election and I'm not quite sure the experience and knowledge of my successor. This means that they might have a difficult time managing a semi-complicated code base (react, redux, firebase, ci/cd etc.)
These are not basic things that people can pick up easily with no prior experiences and rudimentary programming knowledge.

Question

  1. How can we as a community maintain this?
  2. How can we incentivize open source contributions?
  3. How do we ensure code quality and function for the entire school?
  4. Future plans? (template repo? for lwsd?)

Thank you to @theTisch21 and @davidvel25 for contributing currently!
I'm assuming you guys are not seniors. What ideas do you have?

@daniel-sudz do you have any inputs?

Current Ideas

  • Incentivize contribution with community service hours @Zjjc123
  • Update readme to me more contribution friendly @Zjjc123
  • Better introduction and documentation @theTisch21
@Zjjc123 Zjjc123 added help wanted Extra attention is needed question Further information is requested labels May 2, 2021
@Zjjc123 Zjjc123 self-assigned this May 2, 2021
@Zjjc123 Zjjc123 changed the title Future Maintenance of this Project [PROJECT] Future Maintenance of this Project May 2, 2021
@Zjjc123 Zjjc123 added the important Top priority label May 2, 2021
@Zjjc123 Zjjc123 pinned this issue May 2, 2021
@theTisch21
Copy link
Member

I think it should be made clearer that this is open source and open to contributions. I've been using this system all year, and only recently discovered that it was open source, mostly because the link in the footer used to go to the info repo, where I was told I had to request access. I didn't have experience with React (Even though I do have experience with Nodejs), so I didn't apply. I only was added here because of an issue I filed on that info repo. I've made a pull request with some changes that will hopefully make this repo more accessible to those who haven't worked on it before: #144

@daniel-sudz
Copy link
Member

@theTisch21 that's a good point. To avoid confusion I will private the info repo just in case as well.

@daniel-sudz
Copy link
Member

Also @theTisch21 for the screenshots, I never really used it for anything substantial (just when we were testing broken css on the home page at the very start).

Currently it's using browserstack which is why external forks can't get the API key from the repo. I would ideally move any sort of screenshotting to github actions and use something open source there.

A popular framework seems to be https://github.com/cypress-io/cypress currently.

Also, we desperately need end-to-end tests (which cyprus can handle) to make sure we don't break user functionality.

@daniel-sudz
Copy link
Member

Also note: I am currently planing on gap-year/deferring so for now at least, I will be open to continuing to provide PR reviews and making minor contributions.

@theTisch21
Copy link
Member

I am currently a junior, and have another year at Eastlake. I would be willing to help maintain this repo, and I think @davidvel25 would be willing to help as well.

@davidvel25
Copy link
Collaborator

@theTisch21 Sounds good. Yeah I would be willing to work on this project a lot during the summertime and next fall as well. Not so much this school year since AP tests are coming up.

@Sheshank-s
Copy link

hi jason i can help during the next school year

@Nathan-Yap
Copy link
Collaborator

Hi, I also can help. I have experience in React from my time with Sam and Indra.

@Zjjc123
Copy link
Member Author

Zjjc123 commented May 6, 2021

@davidvel25 @Sheshank-s @Nathan-Yap I invited all of you to the tracker team. That should give you triage access for now.

@Sheshank-s
Copy link

Yes I have experience with Sam and Indra too

@Zjjc123
Copy link
Member Author

Zjjc123 commented May 7, 2021

Me too

@theTisch21
Copy link
Member

theTisch21 commented Sep 21, 2021

@Sheshank-s @davidvel25 @Nathan-Yap
Would you like to become code owners and have write access to this repo? That would allow you to approve and merge pull requests whenever @daniel-sudz and @Zjjc123 are unavailable.
@daniel-sudz @Zjjc123 would you approve of this?

@theTisch21
Copy link
Member

@daniel-sudz @Zjjc123
May I please be added as an admin to our @eastlakehs organization? I will attempt to recruit more people to help out, and hopefully recruit some people who won't graduate for a few years. I will then add them as codeowners and give them admin once I graduate.

@Zjjc123
Copy link
Member Author

Zjjc123 commented Sep 23, 2021

I made you an owner of the organization. As with codeowners, I would like to see them make a few good contributions before making them codeowners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed important Top priority question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants