Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Manchester Syntax #248

Open
mrnolte opened this issue Jul 6, 2022 · 8 comments · Fixed by #264
Open

Switch to Manchester Syntax #248

mrnolte opened this issue Jul 6, 2022 · 8 comments · Fixed by #264
Labels
enhancement New feature or request

Comments

@mrnolte
Copy link
Collaborator

mrnolte commented Jul 6, 2022

For reviews, it would be nice to have the ontologies and the changes in Manchester Syntax, which is designed to be human-readable.
It is also the Ontology Language used by Protégé, e.g., to define complex concepts. It might be neccessary to convert the Manchester Syntax to XML for online releases (via the CI).

@sasjonge
Copy link
Collaborator

In issue https://github.com/ease-crc/soma/issues/251we have problems with some GCI's. It looks to me, as if GCI's are deleted in the manchester syntax, so this could be a problem in this issue, too.

@sasjonge sasjonge added the enhancement New feature or request label Jul 15, 2022
@mrnolte
Copy link
Collaborator Author

mrnolte commented Jul 15, 2022

Uli Sattler writes that GCI's are not proper manchester syntax - I will look into that into more detail next week

@mrnolte
Copy link
Collaborator Author

mrnolte commented Jul 18, 2022

image
Protégé tells me the same - either we resolve the GCIs, which seem to cause problems elswehere, too (#251 ) or maybe use functional syntax / turtle syntax instead? Still way easier to read than XML

@mpomarlan
Copy link
Collaborator

+1 for functional syntax :)

This was referenced Jul 22, 2022
sasjonge added a commit that referenced this issue Jul 22, 2022
@mrnolte
Copy link
Collaborator Author

mrnolte commented Jul 22, 2022

This is not closed yet! The .owl files are not in another format yet, as we need to wait for all .owl-file regarding pull requests to be completed. Otherwise, it will be a huge pain to merge these PRs.

@mrnolte mrnolte reopened this Jul 22, 2022
@mrnolte
Copy link
Collaborator Author

mrnolte commented Aug 1, 2022

We could still use Manchester Syntax instead of Functional, if we rewrite the GCIs - and this seems to be possible without leaving EL: for C_1 subclass C_2, where C_1 and C_2 are complex concepts, one would introduce new Concepts A_1 and A_2 and assert C_1 = A_1, A_1 subclass A_2, A_2 = C_2, which gets rid of the CI.
I would prefer this.

@daniel86
Copy link
Member

daniel86 commented Aug 2, 2022

someone also needs to make sure KnowRob can load the ontologies in the other format! might not be a lot of work, but code must be modified I am pretty sure

@mrnolte
Copy link
Collaborator Author

mrnolte commented Aug 2, 2022

someone also needs to make sure KnowRob can load the ontologies in the other format! might not be a lot of work, but code must be modified I am pretty sure

This has been thought through already: We only want to switch the syntax in the git files (for readability in the git changelog / PRs), the CI will then translate them back to rdf xml. This has already been implemented here: #264

Therefore, the published files (via the URIs) will still be in rdf xml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants